Skip to content

fix: preserve Ollama tool calls and pasted approval feedback - #337

Merged
AetherAI3 merged 1 commit into
mainfrom
fix/ollama-call-ids-paste-feedback
Oct 9, 2026
Merged

AetherAI3 merged 1 commit into
mainfrom
fix/ollama-call-ids-paste-feedback

Conversation

@AetherAI3

Copy link
Copy Markdown
Owner

Summary

  • Give every Ollama tool call a unique ID across model replies and carry that ID through the assistant turn, host event, and tool result.
  • Buffer incomplete terminal escape sequences while collecting denial feedback, so split bracketed-paste markers cannot submit a pasted newline or leak text to the next input owner.

Verification

  • npm run build
  • node --test --test-isolation=none dist/test/brain_ollama.test.js dist/test/approval_feedback.test.js dist/test/bridge.test.js (50 passed)
  • git diff --check

Follow-up to the review on #334 by @ability-spec.

@ability-spec

Copy link
Copy Markdown

=)

@AetherAI3
AetherAI3 merged commit 775d81c into main Oct 9, 2026
1 of 8 checks passed
@AetherAI3
AetherAI3 deleted the fix/ollama-call-ids-paste-feedback branch October 9, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants