Add fix to reshow card icon if previously it failed to load #2955
+27
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
|
|
Size Change: +141 B (+0.02%) Total Size: 768 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
ribeiroguilherme
approved these changes
Nov 14, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If an icon in the Credit card PAN field failed to load - an error handler set inline an style
display:none.And this inline style was never removed in the event of a subsequent, successful, icon load.
This PR fixes that
Tested scenarios
New e2e test that was previously flaky or failing due to this - now passes consistently
Manually tested.