Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Custom URLs #2262

Merged
merged 5 commits into from
Aug 24, 2023
Merged

Conversation

ribeiroguilherme
Copy link
Contributor

@ribeiroguilherme ribeiroguilherme commented Jul 12, 2023

Summary

Adding support to new configuration property environmentUrls , which can be used to pass custom URL's for API and CDN. This change targets mainly Pay by Link, and this new property should not be documented externally.

Example of PBL use cases:

  1. Use local environment
environment: 'devl',
environmentUrls: {
  api: 'http://localhost:8080/checkoutshopper/',
},
  1. Use test/live environment, pointing to a different URL
environment: 'test',
environmentUrls: {
  api: 'http://checkout-zeta.com/checkoutshopper/',
},

Tested scenarios

  • Added unit tests
  • Tested by PBL team

Fixed issue: COWEB-1250

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Size Change: +171 B (0%)

Total Size: 1.07 MB

Filename Size Change
packages/lib/dist/adyen.js 283 kB +51 B (0%)
packages/lib/dist/cjs/index.js 245 kB +53 B (0%)
packages/lib/dist/es.modern/index.js 118 kB +20 B (0%)
packages/lib/dist/es/index.js 138 kB +47 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.41 kB
packages/lib/dist/es.modern/cs-CZ.js 5.79 kB
packages/lib/dist/es.modern/da-DK.js 5.27 kB
packages/lib/dist/es.modern/de-DE.js 5.66 kB
packages/lib/dist/es.modern/el-GR.js 7.29 kB
packages/lib/dist/es.modern/es-ES.js 5.36 kB
packages/lib/dist/es.modern/fi-FI.js 5.35 kB
packages/lib/dist/es.modern/fr-FR.js 5.47 kB
packages/lib/dist/es.modern/hr-HR.js 5.49 kB
packages/lib/dist/es.modern/hu-HU.js 5.78 kB
packages/lib/dist/es.modern/it-IT.js 5.34 kB
packages/lib/dist/es.modern/ja-JP.js 6.18 kB
packages/lib/dist/es.modern/ko-KR.js 5.78 kB
packages/lib/dist/es.modern/nl-NL.js 5.37 kB
packages/lib/dist/es.modern/no-NO.js 5.25 kB
packages/lib/dist/es.modern/pl-PL.js 5.76 kB
packages/lib/dist/es.modern/pt-BR.js 5.32 kB
packages/lib/dist/es.modern/pt-PT.js 5.45 kB
packages/lib/dist/es.modern/ro-RO.js 5.58 kB
packages/lib/dist/es.modern/ru-RU.js 6.76 kB
packages/lib/dist/es.modern/sk-SK.js 5.85 kB
packages/lib/dist/es.modern/sl-SI.js 5.43 kB
packages/lib/dist/es.modern/sv-SE.js 5.23 kB
packages/lib/dist/es.modern/zh-CN.js 5.62 kB
packages/lib/dist/es.modern/zh-TW.js 5.74 kB
packages/lib/dist/es/ar.js 6.41 kB
packages/lib/dist/es/cs-CZ.js 5.79 kB
packages/lib/dist/es/da-DK.js 5.27 kB
packages/lib/dist/es/de-DE.js 5.66 kB
packages/lib/dist/es/el-GR.js 7.29 kB
packages/lib/dist/es/es-ES.js 5.36 kB
packages/lib/dist/es/fi-FI.js 5.35 kB
packages/lib/dist/es/fr-FR.js 5.47 kB
packages/lib/dist/es/hr-HR.js 5.49 kB
packages/lib/dist/es/hu-HU.js 5.78 kB
packages/lib/dist/es/it-IT.js 5.34 kB
packages/lib/dist/es/ja-JP.js 6.18 kB
packages/lib/dist/es/ko-KR.js 5.78 kB
packages/lib/dist/es/nl-NL.js 5.37 kB
packages/lib/dist/es/no-NO.js 5.25 kB
packages/lib/dist/es/pl-PL.js 5.76 kB
packages/lib/dist/es/pt-BR.js 5.32 kB
packages/lib/dist/es/pt-PT.js 5.45 kB
packages/lib/dist/es/ro-RO.js 5.58 kB
packages/lib/dist/es/ru-RU.js 6.76 kB
packages/lib/dist/es/sk-SK.js 5.85 kB
packages/lib/dist/es/sl-SI.js 5.43 kB
packages/lib/dist/es/sv-SE.js 5.23 kB
packages/lib/dist/es/zh-CN.js 5.62 kB
packages/lib/dist/es/zh-TW.js 5.74 kB

compressed-size-action

@ribeiroguilherme ribeiroguilherme marked this pull request as ready for review August 4, 2023 12:51
@ribeiroguilherme ribeiroguilherme changed the title [WIP] Adding support for Custom URLs Adding support for Custom URLs Aug 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.7% 95.7% Coverage
0.0% 0.0% Duplication

@ribeiroguilherme ribeiroguilherme merged commit 1532d70 into main Aug 24, 2023
10 checks passed
@ribeiroguilherme ribeiroguilherme deleted the feature/supporting-custom-urls branch August 24, 2023 11:15
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants