Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding metadata upload workflow #1120

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Adding metadata upload workflow #1120

merged 3 commits into from
Jul 17, 2024

Conversation

zenit2001
Copy link
Contributor

@zenit2001 zenit2001 commented Jul 16, 2024 •
edited
Loading

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    Automating the metadata import step.
  • What existing problem does this pull request solve?
    No need to upload metadata manually in case new fields are added.

Tested scenarios

Description of tested scenarios:

  • Automatic metadata field import in case of changes in /metadata folder
  • In case no changes in the /metadata folder, the pipeline will not run

Fixed issue: SFI-58

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@zenit2001 zenit2001 added the excluded Will be ignored in the release notes label Jul 16, 2024
@zenit2001 zenit2001 marked this pull request as ready for review July 16, 2024 13:06
@zenit2001 zenit2001 requested a review from dcardos July 17, 2024 06:45
dcardos
dcardos approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dcardos dcardos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, I assume the timeout of 5 minutes is enough to run the job most of the times.

@zenit2001 zenit2001 merged commit 067dcb1 into develop Jul 17, 2024
17 checks passed
@zenit2001 zenit2001 deleted the feature/SFI-58-automatic_metadata_upload branch July 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanikantsingh shanikantsingh shanikantsingh approved these changes

@dcardos dcardos dcardos approved these changes

@maassenbas maassenbas Awaiting requested review from maassenbas

@amihajlovski amihajlovski Awaiting requested review from amihajlovski amihajlovski is a code owner

Assignees
No one assigned
Labels
excluded Will be ignored in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenit2001 @dcardos @shanikantsingh