Skip to content

Export HttpClientException #1526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 14, 2025
Merged

Export HttpClientException #1526

merged 3 commits into from
Jul 14, 2025

Conversation

gcatanese
Copy link
Contributor

@gcatanese gcatanese commented Jul 11, 2025

Following the great feedback in #1420 the library now exports HttpClientException, allowing to try-catch the Adyen API exceptions without importing directly from the path

Fix #1420

@gcatanese gcatanese requested a review from a team as a code owner July 11, 2025 07:50
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the library's public API by making the HttpClientException class directly accessible. This simplifies error handling for consumers by allowing them to import and catch specific HTTP exceptions without relying on internal module paths, along with adding corresponding test coverage.

Highlights

  • API Usability: The HttpClientException class is now directly exported from the library's main entry point (src/index.ts). This change allows consumers to try-catch Adyen API exceptions more easily without needing to import them from internal, potentially unstable, file paths, improving the overall developer experience for error handling.
  • Test Coverage: A new test file, src/__tests__/httpClientException.spec.ts, has been added. This test suite verifies that HttpClientException is correctly exported as a class and can be instantiated, ensuring its public availability and expected behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly exports HttpClientException to make it accessible to library users, which is a great improvement for error handling. The change is supported by a new test file. I've added one suggestion to improve the new test's readability and maintainability. Overall, this is a good change.

@gcatanese gcatanese force-pushed the export-httpclientexception branch from 35e1beb to 9bd105c Compare July 11, 2025 08:42
Copy link

@gcatanese gcatanese merged commit 48d948f into main Jul 14, 2025
7 checks passed
@gcatanese gcatanese deleted the export-httpclientexception branch July 14, 2025 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definition for error codes and messages
1 participant