OpenAPI v7 Generation: Classic Payments, BalanceControl, Disputes, StoredValue #1510
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request incorporates the latest API specifications for several core Adyen services (Classic Payments, Balance Control, Disputes, Stored Value) by regenerating their TypeScript clients using OpenAPI Generator v7. Alongside the regeneration, the structure of the client library is improved by moving specific service clients into dedicated sub-folders, deprecating the older, top-level files to guide users towards the new structure.
Highlights
- OpenAPI v7 Generation: Updated the client libraries for Classic Payments, Balance Control, Disputes, and Stored Value APIs using OpenAPI Generator version 7.
- Service Reorganization: Moved the generated code for Balance Control, Disputes, and Stored Value APIs into dedicated folders (
services/balanceControl,services/disputes,services/storedValue) for better organization. - Deprecation of Old Services: The previous single files for Balance Control, Disputes, and Stored Value services (
balanceControlApi.ts,disputesApi.ts,storedValueApi.ts) have been deprecated, with references updated to point to the new folder structure. - API Access Changes: Updated test files to reflect the new way of accessing API methods via nested properties on the main service class (e.g.,
service.ApiName.method(...)). - Typings Updates: Generated typings files have been updated to align with the OpenAPI Generator v7 output format, including changes to the
ObjectSerializerand model definitions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request successfully integrates the OpenAPI v7 generated code for Classic Payments, Balance Control, Disputes, and Stored Value APIs. The changes involve moving the service implementations into dedicated folders and updating the test suites to reflect the new structure. The old service files have been appropriately marked as deprecated, guiding users towards the new locations. The updates to the typings files and the introduction of dedicated ObjectSerializer files are consistent with the output of the new generator version. Overall, the changes are well-structured and align with the stated objective.
|
This PR generates several APIs using the OpenAPI Typescript Generator v7:
servicefolder has been deprecatedservicefolder has been deprecatedservicefolder has been deprecated