Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-8888] Implement LineItemsDataBuilder and add lineItems to PayPal requests #2892

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

[ECP-8888] Implement LineItemsDataBuilder and add lineItems to PayPal requests #2892

wants to merge 14 commits into from
+307 −20

Conversation

candemiralp
Copy link
Member

Description

This PR implements a configuration field to determine the requirement for lineItems. This requirement is determined by 2 distinct configuration fields, is_open_invoice and requires_line_items. Open invoice payment methods require lineItems by default and these fields will be added to the requests of open invoice methods. On the other hand, some of the non-open-invoice payment methods also require lineItems. To tackle this challenge, requires_line_items configuration field has been implemented.

lineItems will be added to the requests if one of the is_open_invoice or requires_line_items configuration fields is set to true.

Besides that, this field has been set for PayPal requests in the context of this PR.

Tested scenarios

  • Klarna payment and modifications test
  • PayPal payment and modifications test

@candemiralp candemiralp requested a review from a team as a code owner February 18, 2025 12:27
@candemiralp candemiralp self-assigned this Feb 18, 2025
@candemiralp candemiralp removed their assignment Feb 18, 2025
@candemiralp candemiralp added the Feature Indicates a new feature addition label Feb 18, 2025
@candemiralp candemiralp marked this pull request as draft February 18, 2025 13:11
@candemiralp candemiralp marked this pull request as ready for review February 18, 2025 14:47
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Indicates a new feature addition
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@candemiralp