[ECP-9582] Remove union return type to fix compatibility issue on Magento 2.4.4 and 2.4.5 #2859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushboo-singhvi
approved these changes
Jan 23, 2025
candemiralp
had a problem deploying
to
internal
GitHub Actions
Failure
|
Merged
sena1482
changed the title
|
@candemiralp Just FYI: We faced similar problems in the past on the union return type in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We previously introduced a union return type to
DownloadApplePayDomainAssociationFileclass that broke the compatibility of the plugin with Magento 2.4.4 and 2.4.5, although it is supported with PHP 8. The union return type is now removed from this class.Tested scenarios
Fixes #2842