Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9484] Adobe Commerce solving Security Errors #2794

Merged
merged 21 commits into from
Nov 12, 2024
Merged

[ECP-9484] Adobe Commerce solving Security Errors #2794

merged 21 commits into from
Nov 12, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Nov 1, 2024 •
edited
Loading

Description

There were few direct uses of $_SERVER Superglobal detected and also few warning related to Magento2.Html.HtmlClosingVoidTags.HtmlClosingVoidElements

Tested scenarios

Fixes

@khushboo-singhvi khushboo-singhvi marked this pull request as ready for review November 1, 2024 15:37
@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner November 1, 2024 15:37
@khushboo-singhvi
A scenario was caught while writing unit test, After mocking, When I …
07c3c86 
…try to access $_SERVER['PHP_AUTH_USER'], it shows correct mocked value, But when I try to access $this->request->getServer('PHP_AUTH_USER'), it throws null,

This issue likely arises because $_SERVER is populated directly from the server environment variables, but getServer() in Magento might not have access to all the server variables if they’re not set in a way that Magento’s Request class can access.

The only direct solution I found was using $_SERVER directly after setting, since they are available globally in PHP once populated.
@khushboo-singhvi
Merge remote-tracking branch 'origin/ECP-9484' into ECP-9484
02ee38c
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khushboo-singhvi khushboo-singhvi merged commit e9d13e1 into main Nov 12, 2024
13 of 14 checks passed
@khushboo-singhvi khushboo-singhvi deleted the ECP-9484 branch November 12, 2024 09:11
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

@peterojo peterojo peterojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushboo-singhvi @peterojo @candemiralp