Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9506] Fix /payments response handling if an exception is thrown #2763

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[ECP-9506] Fix /payments response handling if an exception is thrown #2763

merged 2 commits into from
Oct 4, 2024

Conversation

candemiralp
Copy link
Member

Description

This PR fixes the /payments response handling if an exception is thrown while sending the HTTP request.

Tested scenarios

  • Test a case where Checkout API throws 500 internal error

@candemiralp candemiralp requested a review from a team as a code owner October 3, 2024 15:21
peterojo
peterojo previously approved these changes Oct 3, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@candemiralp candemiralp merged commit 1935d6f into main Oct 4, 2024
15 of 16 checks passed
@candemiralp candemiralp deleted the ECP-9506 branch October 4, 2024 06:53
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khushboo-singhvi khushboo-singhvi khushboo-singhvi approved these changes

@peterojo peterojo peterojo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@candemiralp @peterojo @khushboo-singhvi