Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all services #345

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Update all services #345

merged 4 commits into from
Aug 15, 2024

Conversation

AdyenAutomationBot
Copy link
Collaborator

@AdyenAutomationBot AdyenAutomationBot commented Jul 18, 2024 •
edited
Loading

OpenAPI spec or templates produced changes on 14-08-2024 by commit.

@AdyenAutomationBot AdyenAutomationBot requested review from gcatanese and a team as code owners July 18, 2024 10:03
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 6 times, most recently from 1223c79 to 8acb604 Compare July 26, 2024 13:19
@sonarqubecloud SonarQubeCloud
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 4 times, most recently from 785437f to 65a6bc5 Compare July 31, 2024 16:14
@DjoykeAbyah
Copy link
Member

DjoykeAbyah commented Aug 1, 2024 •
edited
Loading

⚠️ Changes ⚠️

  • Configuration Webhooks v1 to v2

Removed in: src/configurationwebhook/model_balance_account.go. PaymentInstruments class, enums to lower-case


Removed in:src/configurationwebhook/model_account_holder.go

Inactive

Changed in: src/configurationwebhook/model_balance_account.go
src/configurationwebhook/model_phone.go Enums to lowercase

Changed in: src/configurationwebhook/model_card.go
Contact to DeliveryContact

Removed and changed in: src/configurationwebhook/model_payment_instrument.go

  • Blocked
  • Stolen
  • Requested
  • Lost
  • Discarded

Enums to lowercase

Removed in :src/transfers/model_party_identification.go fullName string

Changes in :src/transfers/model_transfer.go
src/transferwebhook/model_transfer_data.go
Added:

  • Card

Removed:

  • cashOutFee
  • cashOutFunding
    ! Use cashoutFee and cashoutFunding instead !

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 2 times, most recently from 5e236f6 to ffb6bd8 Compare August 5, 2024 13:51
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/models branch 2 times, most recently from e6b20fe to 599a3d7 Compare August 7, 2024 13:54
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jillingk jillingk enabled auto-merge (squash) August 15, 2024 13:38
@jillingk jillingk merged commit 2366dce into main Aug 15, 2024
4 of 5 checks passed
@jillingk jillingk deleted the sdk-automation/models branch August 15, 2024 13:41
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Aug 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillingk jillingk jillingk approved these changes

@gcatanese gcatanese Awaiting requested review from gcatanese

Assignees
No one assigned
Labels
Breaking change Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdyenAutomationBot @DjoykeAbyah @jillingk