Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #1367

Merged
merged 42 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
3810565
Merge pull request #1338 from Adyen/main
jreij Sep 7, 2023
b510df0
Update dependency androidx.annotation:annotation to v1.7.0
renovate[bot] Sep 7, 2023
ada67e8
Merge pull request #1336 from Adyen/renovate/annotation_version
jreij Sep 7, 2023
5544b7b
Update hilt_version to v2.48
renovate[bot] Sep 7, 2023
469eaef
Merge pull request #1326 from Adyen/renovate/hilt_version
jreij Sep 7, 2023
5b932a9
Update plugin org.jetbrains.dokka to v1.9.0
renovate[bot] Sep 7, 2023
bf71c93
Merge pull request #1329 from Adyen/renovate/dokka_version
jreij Sep 7, 2023
8ea3baa
Update actions/checkout action to v4
renovate[bot] Sep 7, 2023
30d9f5c
Merge pull request #1330 from Adyen/renovate/actions-checkout-4.x
jreij Sep 7, 2023
97ec42b
Update dependency androidx.compose:compose-bom to v2023.09.00
renovate[bot] Sep 7, 2023
ee47451
Update gradle verification metadata
jreij Sep 7, 2023
8c0a108
Merge pull request #1337 from Adyen/renovate/compose_bom_version
jreij Sep 7, 2023
7b13123
Update dependency androidx.lifecycle:lifecycle-viewmodel-compose to v…
renovate[bot] Sep 7, 2023
345c7d8
Update gradle verification metadata
jreij Sep 7, 2023
4db7f09
Merge pull request #1335 from Adyen/renovate/compose_viewmodel_version
jreij Sep 7, 2023
9cd9bc4
Display new view in drop-in on next render
OscarSpruit Sep 19, 2023
4e24344
Merge pull request #1342 from Adyen/fix/jumping_bottom_sheet
OscarSpruit Sep 22, 2023
827b372
Propagate view errors to the component for WeChat
OscarSpruit Sep 19, 2023
ccda32a
Merge pull request #1343 from Adyen/fix/wechat_cancel_button
OscarSpruit Sep 22, 2023
e9d2d7e
Send customer id for one time Cash App payment
OscarSpruit Sep 20, 2023
739c6ec
Merge pull request #1345 from Adyen/fix/cash_app_customerid
OscarSpruit Sep 25, 2023
848515c
Update dependency com.google.android.gms:play-services-wallet to v19.2.1
renovate[bot] Sep 25, 2023
82a5ec4
Merge pull request #1339 from Adyen/renovate/play_services_wallet_ver…
jreij Sep 29, 2023
0e3d592
Set loading state before calling remove stored payment method callback
OscarSpruit Sep 28, 2023
f8d5bde
Merge pull request #1351 from Adyen/fix/remove_spm_infinite_loading
OscarSpruit Oct 2, 2023
c197437
Handle deep links for instant example correctly
OscarSpruit Sep 20, 2023
5caf5de
Merge pull request #1344 from Adyen/fix/deep_links_instant_example
OscarSpruit Oct 2, 2023
d74aa65
Remove Amount.EMPTY
ozgur00 Sep 29, 2023
b73deed
Merge pull request #1353 from Adyen/refactor/amount
jreij Oct 6, 2023
72405b0
Disable phone number collection of 3DS2 SDK
OscarSpruit Sep 29, 2023
acb75a8
Move 3DS2 param block list to component parameters
OscarSpruit Oct 2, 2023
61ba5a9
Merge pull request #1354 from Adyen/fix/3ds2_data_collection
OscarSpruit Oct 6, 2023
bb4d6a4
Add ProGuard rules for Retrofit
OscarSpruit Oct 2, 2023
97d3c81
Merge pull request #1355 from Adyen/fix/example_app_obfuscation
OscarSpruit Oct 6, 2023
9a8e42e
Remove @RestrictTo from classes that are indirectly exposed
OscarSpruit Oct 11, 2023
68de2f0
Merge pull request #1360 from Adyen/fix/restrictto_warnings
OscarSpruit Oct 16, 2023
6ad8d34
Update version to 5.0.0
jreij Oct 13, 2023
505e949
Update README.md
jreij Oct 13, 2023
e24f8c3
Update RELEASE_NOTES.md for 5.0.0
jreij Oct 13, 2023
3999b6d
Merge pull request #1365 from Adyen/release/5.0.0
jreij Oct 18, 2023
ce61123
Improve error handling and logging for analytics and image loader
jreij Oct 18, 2023
e54b3ab
Merge pull request #1366 from Adyen/fix/error_logging
jreij Oct 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/assemble.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
# https://github.com/marketplace/actions/checkout
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Setup Java 17
# https://github.com/marketplace/actions/setup-java-jdk
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code_analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
Expand All @@ -29,7 +29,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/generate_dependency_graph.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}
fetch-depth: 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
# https://github.com/marketplace/actions/checkout
- uses: actions/checkout@v3
- uses: actions/checkout@v4

# Setup Java 17
# https://github.com/marketplace/actions/setup-java-jdk
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: main

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/run_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
Expand All @@ -34,7 +34,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Set up JDK
uses: actions/setup-java@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update_verification_metadata.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
ref: ${{ github.head_ref }}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class Adyen3DS2Configuration private constructor(
override val environment: Environment,
override val clientKey: String,
override val analyticsConfiguration: AnalyticsConfiguration?,
override val amount: Amount,
override val amount: Amount?,
val uiCustomization: UiCustomization?,
val threeDSRequestorAppURL: String?,
) : Configuration {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,9 @@ internal class DefaultAdyen3DS2Delegate(
fingerprintToken.directoryServerPublicKey,
// directoryServerRootCertificates
fingerprintToken.directoryServerRootCertificates,
).build()
)
.deviceParameterBlockList(componentParams.deviceParameterBlockList)
.build()

val coroutineExceptionHandler = CoroutineExceptionHandler { _, throwable ->
Logger.e(TAG, "Unexpected uncaught 3DS2 Exception", throwable)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ internal data class Adyen3DS2ComponentParams(
override val clientKey: String,
override val analyticsParams: AnalyticsParams,
override val isCreatedByDropIn: Boolean,
override val amount: Amount,
override val amount: Amount?,
val uiCustomization: UiCustomization?,
val threeDSRequestorAppURL: String?,
val deviceParameterBlockList: Set<String>?,
) : ComponentParams
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

package com.adyen.checkout.adyen3ds2.internal.ui.model

import androidx.annotation.VisibleForTesting
import com.adyen.checkout.adyen3ds2.Adyen3DS2Configuration
import com.adyen.checkout.components.core.internal.ui.model.AnalyticsParams
import com.adyen.checkout.components.core.internal.ui.model.ComponentParams
Expand Down Expand Up @@ -38,6 +39,8 @@ internal class Adyen3DS2ComponentParamsMapper(
amount = amount,
uiCustomization = uiCustomization,
threeDSRequestorAppURL = threeDSRequestorAppURL,
// Hardcoded for now, but in the feature we could make this configurable
deviceParameterBlockList = DEVICE_PARAMETER_BLOCK_LIST,
)
}

Expand All @@ -63,4 +66,11 @@ internal class Adyen3DS2ComponentParamsMapper(
amount = sessionParams.amount ?: amount,
)
}

companion object {
private const val PHONE_NUMBER_PARAMETER = "A005"

@VisibleForTesting
internal val DEVICE_PARAMETER_BLOCK_LIST = setOf(PHONE_NUMBER_PARAMETER)
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ import com.adyen.threeds2.exception.InvalidInputException
import com.adyen.threeds2.exception.SDKRuntimeException
import com.adyen.threeds2.parameters.ChallengeParameters
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.ExperimentalCoroutinesApi
import kotlinx.coroutines.test.TestDispatcher
import kotlinx.coroutines.test.runTest
import org.json.JSONException
Expand All @@ -66,7 +65,6 @@ import org.mockito.kotlin.whenever
import java.io.IOException
import java.util.Locale

@OptIn(ExperimentalCoroutinesApi::class)
@ExtendWith(MockitoExtension::class, TestDispatcherExtension::class)
internal class DefaultAdyen3DS2DelegateTest(
@Mock private val submitFingerprintRepository: SubmitFingerprintRepository,
Expand All @@ -89,7 +87,9 @@ internal class DefaultAdyen3DS2DelegateTest(
observerRepository = ActionObserverRepository(),
savedStateHandle = SavedStateHandle(),
componentParams = Adyen3DS2ComponentParamsMapper(null, null)
.mapToParams(configuration, null),
.mapToParams(configuration, null)
// Set it to null to avoid a crash in 3DS2 library (they use Android APIs)
.copy(deviceParameterBlockList = null),
submitFingerprintRepository = submitFingerprintRepository,
paymentDataRepository = paymentDataRepository,
adyen3DS2Serializer = adyen3DS2Serializer,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ internal class Adyen3DS2ComponentParamsMapperTest {
clientKey: String = TEST_CLIENT_KEY_1,
analyticsParams: AnalyticsParams = AnalyticsParams(AnalyticsParamsLevel.ALL),
isCreatedByDropIn: Boolean = false,
amount: Amount = Amount.EMPTY,
amount: Amount? = null,
uiCustomization: UiCustomization? = null,
threeDSRequestorAppURL: String? = null,
) = Adyen3DS2ComponentParams(
Expand All @@ -117,6 +117,7 @@ internal class Adyen3DS2ComponentParamsMapperTest {
amount = amount,
uiCustomization = uiCustomization,
threeDSRequestorAppURL = threeDSRequestorAppURL,
deviceParameterBlockList = Adyen3DS2ComponentParamsMapper.DEVICE_PARAMETER_BLOCK_LIST,
)

companion object {
Expand Down
Loading