Skip to content

Fix the background output format issue #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Fix the background output format issue #185

merged 1 commit into from
May 30, 2025

Conversation

Kvieta1990
Copy link
Collaborator

Description

When saving the background via Background => Save ... as a .pwdrbck file, the original code would output something like,

#GSAS-II background parameter file; do not add/delete items!
['chebyschev-1', True, 6, np.float(0.054985058337585824), ...]
nDebye:0
debyeTerms:[]
nPeaks:0
peaksList:[]
background PWDR:['', 1.0, False]
autoPrms:{}

This was only the case for Windows. This PR is to fix this issue by converting those numpy float64 numbers to float before output.

Test

Here is a Si project file that can be used for testing,
2023A_GSAS_II.ZIP

@Kvieta1990 Kvieta1990 requested a review from briantoby May 23, 2025 01:41
@Kvieta1990 Kvieta1990 self-assigned this May 23, 2025
@Kvieta1990 Kvieta1990 added the bug Something isn't working label May 23, 2025
Copy link
Collaborator

@briantoby briantoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@briantoby briantoby merged commit f0afffd into main May 30, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants