New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indexing #102

Open

briantoby wants to merge 4 commits into master from indexing

Collaborator

briantoby commented Nov 14, 2024

Summarizing changes so far in this branch

GSASIIdataGUI.py

make sure initialization of self.HKL (G2frame.HKL) is to np.array([])
(I saw an error where plotting failed due to trying to perform G2frame.HKL.T on a list)
Clear status bar before display of data tree items
(prevents stale msgs from persisting)
Move plotting into UpdateUnitCellsGrid

GSASIIpwdGUI.py

initialization of G2frame.HKL always as np.array()
OnTryAll: avoid error if OnHklShow returns an empty list or ssopt['SgResults'] is empty
onHklShow: extensive comments; move SetItemPyData(...peaks) to where peaks is changed
lines 6088 to 6594: extensive GUI reorg
6608: end UpdateUnitCells with a call to OnHklShow
so that that the displayed cell/sym is what is shown on plot

GSASIIpwdplot.py

more comments
2448-2456: even if there are no peaks, still show reflections

briantoby added 3 commits

November 13, 2024 12:02


          checkpoint after reorg of GUI

0fddd14


          checkpoint: reorg reflection generation, but more work needed

499f92e


          checkpoint: cosmetic change; pause to reconcile w/Bob

0b651c3

Collaborator Author

briantoby commented Nov 14, 2024

This work is intended to address #44 but is paused as Bob has been working on the same things.


          update with changes in master

667ee23

briantoby linked an issue

that may be closed by this pull request

inconsistencies in reflection generation #44

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet