Skip to content
This repository was archived by the owner on Jan 24, 2021. It is now read-only.

Implemented column override for EntityListViewColumns liquid objects … #115

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MscrmTools
Copy link

…based on Entitylist configuration

When creating a custom web template to render an EntityList, configuration to override columns name and width is not implemented.

This PR adds the required code so that this configuration is honored when rendering an Entitylist using DotLiquid

@amervitz
Copy link
Contributor

amervitz commented Jun 6, 2019

Please supply the liquid code used to render the entity list so that we can validate this change.

Does this issue also affect online portals or has it been fixed there already? Before making such a change, it would need to be confirmed to work in online portals to ensure that users who upgrade to it will not lose functionality.

@MscrmTools
Copy link
Author

Hi,
So I finally found time to test it in online portal. The problem is not fixed online.

Here is the really simple web template I'm using. It only displays columns name

{% entitylist id:page.adx_entitylist.id, enable_entity_permissions:true %}
{% entityview id:params.view, enable_entity_permissions:true, search:params.search, order:params.order, page:params.page, pagesize:params.pagesize, metafilter:params.mf %}
{% for c in entityview.columns -%}
<p>{{c.name}}</p>
{% endfor -%}
{% endentityview %}
{% endentitylist %}

And here is the EntityList configuration
image

And the result
image

As you can see, the column "Average Download count" is not overriden with "Avg DL count"

@MscrmTools
Copy link
Author

I had misread your comment. Does it mean that this open source project is not meant to fix bugs if these bugs have not been fixed in Dynamics Portal Online first?

@amervitz
Copy link
Contributor

We will need to wait until Microsoft fixes it in the online version before accepting this change into his code base. Otherwise the migration path for users of this project to the online version is compromised because they could depend on this change that then would stop working after migrating.

In the meantime we can leave this PR open and merge it in once the issue is fixed in the online version, and people can refer to this PR if they are affected and want to add the changes to their local code base.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants