Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with node-red-dashboard v3 #86

Open
jdotbdot opened this issue Sep 22, 2021 · 5 comments
Open

Incompatibility with node-red-dashboard v3 #86

jdotbdot opened this issue Sep 22, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@jdotbdot
Copy link

Attempting via npm v7 to update node-red-dashboard from 2.30.0 to the current release 3.0.4 fails if node-red-contrib-ui-led is installed:
npm ERR! code ERESOLVE
npm ERR! While resolving: node-red-contrib-ui-led@0.4.9
npm ERR! Found: node-red-dashboard@3.0.4
npm ERR! node_modules/node-red-dashboard
npm ERR! node-red-dashboard@"3.0.4" from the root project
npm ERR! Could not resolve dependency:
npm ERR! peer node-red-dashboard@"^2.23.3" from node-red-contrib-ui-led@0.4.9
npm ERR! node_modules/node-red-contrib-ui-led
npm ERR! node-red-contrib-ui-led@"^0.4.9" from the root project

@colinl
Copy link

colinl commented Sep 23, 2021

The problem is that with npm v7 the peer dependency on the dashboard ^2.23.3 specified in package.json is now treated as an error rather than a warning. A workaround is to install from the command line with the option --legacy-peer-deps which drops it back to being a warning.
The fix is to remove the peer dependency or possibly to change it to requiring at least 2.23.3 rather than at least, but <v3.

@yoiang
Copy link
Member

yoiang commented Sep 29, 2021

Sorry for the late reply, this should be fixed with the PR @EkiSkyten contributed, now merged with other updated dependencies! Let me know if this resolves the issue.

@yoiang yoiang added the bug Something isn't working label Sep 29, 2021
@colinl
Copy link

colinl commented Oct 11, 2021

Unfortunately no, it hasn't fixed it. package.json still (in version 0.4.10) includes the lines

  "peerDependencies": {
    "node-red-dashboard": "^2.23.3"
  },

The PR fixes it in devDependencies but not in peerDependencies

@colinl
Copy link

colinl commented Oct 11, 2021

For anyone finding this issue, the workaround till it is fixed is to install using
npm install --legacy-peer-deps node-red-contrib-ui-led

@yoiang
Copy link
Member

yoiang commented Oct 11, 2021

@colinl arg, I don't know how I missed that, fixed in 0.4.11!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants