Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise to avoid peer warning messages? #73

Closed
Nodi-Rubrum opened this issue Feb 20, 2021 · 5 comments
Closed

Revise to avoid peer warning messages? #73

Nodi-Rubrum opened this issue Feb 20, 2021 · 5 comments

Comments

@Nodi-Rubrum
Copy link

Revise to avoid peer warning messages? For example...
npm WARN node-red-contrib-ui-led@0.4.4 requires a peer of node-red@^1.2.6 but none is installed. You must install peer dependencies yourself.

@yoiang
Copy link
Member

yoiang commented Feb 20, 2021

Are you getting this when you install via the Node-RED palette?

@Nodi-Rubrum
Copy link
Author

Nope, when I install via npm cli.

@randomhammer
Copy link

This looks similar to the error I just opened (#84) that is preventing me from installing the widget from the palette. In my case the peer it is looking for is node-red-dashboard@2.23.2.

@yoiang
Copy link
Member

yoiang commented Sep 29, 2021

Hello @Nodi-Rubrum , node-red is no longer marked as a peer dependency so you should not see the message in future versions!

Hello @randomhammer , this as been resolved in PR #87, released in version 0.4.10, tracked in #86 . Please let me know there if that resolves the issue!

@yoiang yoiang closed this as completed Sep 29, 2021
@colinl
Copy link

colinl commented Oct 11, 2021

Unfortunately this hasn't fixed the problem.
package.json still (in version 0.4.10) includes the lines

"peerDependencies": {
"node-red-dashboard": "^2.23.3"
},

The PR fixes it in devDependencies but not in peerDependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants