Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add snyk docker scanning feature #304

Merged
merged 1 commit into from
Jan 27, 2021
Merged

chore: Add snyk docker scanning feature #304

merged 1 commit into from
Jan 27, 2021

Conversation

grzesuav
Copy link
Contributor

DO NOT MERGE

@grzesuav grzesuav force-pushed the snyk-test branch 4 times, most recently from dd67e63 to 44ed0de Compare March 25, 2020 21:49
@karianna
Copy link
Member

@grzesuav Can we close this now?

@grzesuav
Copy link
Contributor Author

@karianna not yet, still build does not work (they are passing but in fact they are not) I will close the other one and let you know once this is ready

@grzesuav grzesuav force-pushed the snyk-test branch 4 times, most recently from 82fa1b7 to ae493cb Compare March 25, 2020 22:40
@karianna karianna added this to the March 2020 milestone Mar 25, 2020
@grzesuav grzesuav force-pushed the snyk-test branch 2 times, most recently from c0ea923 to 6956814 Compare March 25, 2020 23:54
@grzesuav grzesuav changed the title test: Test snyk auth token from same repository chore: Add snyk docker scanning feature Mar 25, 2020
@grzesuav grzesuav mentioned this pull request Mar 25, 2020
Closed
@karianna karianna modified the milestones: March 2020, April 2020 Apr 1, 2020
@karianna karianna modified the milestones: April 2020, May 2020 May 1, 2020
@karianna karianna modified the milestones: May 2020, June 2020 Jun 2, 2020
@karianna karianna modified the milestones: June 2020, July 2020 Jul 1, 2020
@karianna karianna modified the milestones: July 2020, August 2020 Aug 4, 2020
@karianna karianna removed this from the August 2020 milestone Sep 15, 2020
@karianna karianna added this to the September 2020 milestone Sep 15, 2020
@karianna karianna modified the milestones: September 2020, October 2020 Oct 1, 2020
@karianna karianna modified the milestones: October 2020, November 2020 Nov 5, 2020
@karianna karianna modified the milestones: November 2020, December 2020 Dec 1, 2020
@karianna
Copy link
Member

@grzesuav Merge conflict

@grzesuav
Copy link
Contributor Author

thank you, will adjust it over the week

@grzesuav grzesuav force-pushed the snyk-test branch 6 times, most recently from dee3e59 to fb34fd0 Compare January 24, 2021 20:22
@grzesuav
chore: Add snyk docker scanning feature
1617fb5 
Signed-off-by: grzesuav <grzesuav@gmail.com>
@grzesuav
Copy link
Contributor Author

@karianna fixed. Actually I think it can be merged, until API token won't be present the snyk analysis won't run. We can later on set this token on one particular machine to test it. What do you think ?

karianna
karianna approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Member

@karianna fixed. Actually I think it can be merged, until API token won't be present the snyk analysis won't run. We can later on set this token on one particular machine to test it. What do you think ?

Yeah, I think that's OK. grab me on slack tomorrow and we can try ot figure out how to add the token.

@karianna karianna merged commit c15c9cf into master Jan 27, 2021
@grzesuav grzesuav deleted the snyk-test branch January 27, 2021 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@dinogun dinogun Awaiting requested review from dinogun

Assignees
No one assigned
Labels
enhancement wontfix
Projects
None yet
Milestone
December 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@grzesuav @karianna