chore: Introduce shellcheck to lint .sh scripts #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fail on travis, as shellcheck finding were not fixed yet. Will propose on slack channel and if we want this I do followup commit with fixes to .sh files |
grzesuav
force-pushed
the
add_shellcheck
branch
2 times, most recently
from
50d7e97
to
dd212b0
Compare
karianna
reviewed
Jan 12, 2020
|
Shellcheck would be nice given that this repo is all about scripts ! |
|
@grzesuav Merge conflict... |
grzesuav
force-pushed
the
add_shellcheck
branch
from
279c9da
to
d147efb
Compare
|
@dinogun workin on this, but some changes are hard to verify without running. What is the best way to check that image generation is working (without the necessity to perform running all of them ) ? |
grzesuav
commented
Jan 21, 2020
grzesuav
force-pushed
the
add_shellcheck
branch
from
3cbe558
to
0320aeb
Compare
grzesuav
force-pushed
the
add_shellcheck
branch
2 times, most recently
from
d26b6a0
to
95bdbfe
Compare
grzesuav
force-pushed
the
add_shellcheck
branch
2 times, most recently
from
dfff9a8
to
f349b72
Compare
grzesuav
force-pushed
the
add_shellcheck
branch
from
f349b72
to
a954643
Compare
grzesuav
force-pushed
the
add_shellcheck
branch
from
418bdf8
to
306c2e4
Compare
dinogun
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.