Adobe Campaign Classic clean up #630

calebk1 · 2021-09-03T23:45:07Z

No description provided.

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-event-reference.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

using-mobile-extensions/adobe-campaignclassic/README.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

emdobrin · 2021-09-28T16:46:58Z

@calebk1 we provided some feedback on this PR, let us know if you are still working on it or when you need the final review.

using-mobile-extensions/adobe-campaignclassic/README.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-event-reference.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

swarna04 · 2021-11-30T16:46:39Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

@@ -240,19 +249,27 @@ public void onResume() {
 {% endtab %}

 {% tab title="iOS" %}
-### trackNotificationClick
+{% hint style="info"}
+You can pass the `launchOptions` that was received before opening the application or `userInfo`, which contains the received push payload in `trackInfo`. If `trackInfo` is null or does not contain the necessary tracking identifiers, `broadlogId` (`_mId`) and `deliveryId` (`_dId`), a track request is **not** sent.


... launchOptions dictionary that was received upon opening the application...

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-event-reference.md

swarna04 · 2021-11-30T17:45:58Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md


 The `registerDevice` API registers a device with your Campaign Classic registration server. It takes the APNS token as a parameter with a user key that identifies a user, such as an email address or a login name. You can also provide a map of the custom key-value pairs that you want to associate with the registration. A boolean value is returned in the callback, which signals whether the registration was successful.
+{% endhint %}
+
+### Swift


Have we done this change in other extension docs too? I find this format a little odd

Swift -> Example Objective-C - > Syntax, Example

(1) We should include syntax with Swift too; or
(2) Keep syntax first (Objective-C only in case of 2.x) and then include Swift/ Objective-C examples. Refer to - https://aep-sdks.gitbook.io/docs/using-mobile-extensions/adobe-target/target-api-reference#displayedlocations

Thoughts?

Yeah, I should also include the syntax for it - that being said, I didn't have the syntax, which is why I wasn't sure what to add.

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

swarna04 · 2021-12-02T08:48:38Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+**Syntax**
+
+```swift
+func registerDevice(deviceToken: Token, userKey: String, additionalParams: @escaping (Bool) -> Void)


The correct syntax here is

func registerDevice(_ token: Data, userKey: String?, additionalParams: [String: Any]?, callback: ((Bool) -> Void)?)

swarna04 · 2021-12-02T08:49:47Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+**Syntax**
+
+```swift
+func trackNotificationReceive(trackInfo: [String: String])


The correct syntax here is

func trackNotificationReceive(_ trackInfo: [String: String])

swarna04 · 2021-12-02T08:50:16Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+**Syntax**
+
+```swift
+func trackNotificationClick(trackInfo: [String: String])


The correct syntax here is

func trackNotificationClick(_ trackInfo: [String: String])

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

swarna04 · 2021-12-02T09:58:53Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md


-#### Syntax
+```swift
+ACPCampaignClassic.trackNotificationClick(trackInfo[String:String])


Example

func userNotificationCenter(_ center: UNUserNotificationCenter, didReceive response: UNNotificationResponse, withCompletionHandler completionHandler: @escaping () -> Void) { guard let userInfo = response.notification.request.content.userInfo as? [String: String] else { return } ACPCampaignClassic.trackNotificationClick(userInfo) completionHandler() }

swarna04 · 2021-12-02T10:30:19Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+func registerDevice(deviceToken: Token, userKey: String, additionalParams: @escaping (Bool) -> Void)
+```
+
+**Example**


Example

func application(_ application: UIApplication, didRegisterForRemoteNotificationsWithDeviceToken deviceToken: Data) { let params: [String: Any] = [ "name": "John", "serial": 12345, "premium": true ] ACPCampaignClassic.registerDevice(deviceToken, userKey: "johndoe@gmail.com", additionalParams: params) { result in print("Registration status: \(result)") } }

emdobrin · 2021-12-21T20:42:19Z

@calebk1 thank you for all the updates so far, can you please review the final round of feedback from Swarna?

calebk1 · 2021-12-21T22:28:08Z

Oooh somehow I didn't notice the last set of comments - I should be able to get to this some time tomorrow!

emdobrin

@calebk1 looks good with minor suggestions, feel free to merge once resolved.

emdobrin · 2021-12-22T19:48:22Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+            "serial": 12345,
+            "premium": true
+        ]
+        ACPCampaignClassic.registerDevice(deviceToken, userKey: "johndoe@gmail.com", additionalParams: params) { result in


can we update this to john@example.com and any other occurrences?

emdobrin · 2021-12-22T20:02:05Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-event-reference.md

+        "deviceManufacturer": "unknown",
+        "deviceUuid": "00000000-3398-7b70-0000-000033987b70"
+    },
+    "userKey": "john.doe@adobe.com"


john@example.com

emdobrin · 2021-12-22T20:30:40Z

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md

+      }
+      ACPCampaignClassic.trackNotificationClick(userInfo)
+      completionHandler()
+}
 ```

 ### Objective-C


the format for the obj-c example below is a little off L330-331, can we fix that too?

[ACPCampaignClassic trackNotificationClick:response.notification.request.content.userInfo]; completionHandler();

resolved

calebk1 and others added 4 commits September 2, 2021 14:52

updated the API reference

ee8fa61

Merge branch 'master' into campaign-classic

48fd52e

Starting to go through the README

d51b534

Merge branch 'master' into campaign-classic

aba4e9e

emdobrin reviewed Sep 16, 2021

View reviewed changes

emdobrin requested a review from shtomar-adb September 16, 2021 03:24

shtomar-adb requested a review from rymorale September 16, 2021 18:42

rymorale reviewed Sep 17, 2021

View reviewed changes

using-mobile-extensions/adobe-campaignclassic/README.md Outdated Show resolved Hide resolved

rymorale reviewed Sep 17, 2021

View reviewed changes

using-mobile-extensions/adobe-campaignclassic/adobe-campaignclassic-api-reference.md Outdated Show resolved Hide resolved

calebk1 added 3 commits November 15, 2021 16:27

Fix merge conflicts

2b40393

Fixes according to review

8377ac9

More fixes

90c633c

swarna04 self-requested a review November 29, 2021 22:00

swarna04 requested changes Nov 30, 2021

View reviewed changes

calebk1 added 2 commits November 30, 2021 15:40

Merge branch 'master' into campaign-classic

4f30aa2

Fixes

4cdc34e

swarna04 previously requested changes Dec 2, 2021

View reviewed changes

Final fixes

9b0da90

emdobrin approved these changes Dec 22, 2021

View reviewed changes

Final fixes

e35dd98

calebk1 merged commit 020c194 into Adobe-Marketing-Cloud:master Dec 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adobe Campaign Classic clean up #630

Adobe Campaign Classic clean up #630

calebk1 commented Sep 3, 2021 •

edited

Loading

emdobrin commented Sep 28, 2021

swarna04 Nov 30, 2021

swarna04 Nov 30, 2021

calebk1 Dec 1, 2021

swarna04 Dec 2, 2021

swarna04 Dec 2, 2021

swarna04 Dec 2, 2021

swarna04 Dec 2, 2021

swarna04 Dec 2, 2021

emdobrin commented Dec 21, 2021

calebk1 commented Dec 21, 2021

emdobrin left a comment

emdobrin Dec 22, 2021

emdobrin Dec 22, 2021

emdobrin Dec 22, 2021

Adobe Campaign Classic clean up #630

Adobe Campaign Classic clean up #630

Conversation

calebk1 commented Sep 3, 2021 • edited Loading

emdobrin commented Sep 28, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emdobrin commented Dec 21, 2021

calebk1 commented Dec 21, 2021

emdobrin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

calebk1 commented Sep 3, 2021 •

edited

Loading