Page injector updates #3304
Merged
Page injector updates #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 29, 2024 09:57
…o use currentPage, not resource Page Add PageProperty which only uses current page or resource page Add via providers
# Conflicts: # bundle/src/main/java/com/adobe/acs/commons/models/injectors/annotation/HierarchicalPageProperty.java # bundle/src/main/java/com/adobe/acs/commons/models/injectors/annotation/PageProperty.java # bundle/src/main/java/com/adobe/acs/commons/models/injectors/impl/HierarchicalPagePropertyInjector.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3304 +/- ##
=========================================
Coverage 55.42% 55.42%
- Complexity 5529 5543 +14
=========================================
Files 723 725 +2
Lines 29623 29660 +37
Branches 3858 3865 +7
=========================================
+ Hits 16419 16440 +21
- Misses 11663 11677 +14
- Partials 1541 1543 +2 ☔ View full report in Codecov by Sentry. |
davidjgonzalez
approved these changes
Apr 2, 2024
davidjgonzalez
merged commit 9b66e71
into
Adobe-Consulting-Services:master
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some options, add via providers