Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dialog provider improvements #2012

Merged
merged 6 commits into from
Aug 1, 2019

Conversation

badvision
Copy link
Contributor

Adding support for the autocomplete and ACS query autocomplete extension

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@badvision badvision added this to the 4.3.0 milestone Jul 31, 2019
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4911

  • 19 of 27 (70.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 54.292%

Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/form/FieldComponent.java 4 5 80.0%
bundle/src/main/java/com/adobe/acs/commons/mcp/form/AutocompleteComponent.java 15 22 68.18%
Totals Coverage Status
Change from base Build 4907: 0.02%
Covered Lines: 14308
Relevant Lines: 26354

💛 - Coveralls

@badvision badvision merged commit 30929b6 into master Aug 1, 2019
@badvision badvision deleted the feature/dialog_provider_improvements branch August 1, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants