Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix possibly negative index #1776

Merged
merged 7 commits into from
Mar 22, 2019
Merged

fix possibly negative index #1776

merged 7 commits into from
Mar 22, 2019

Conversation

Nov11
Copy link
Contributor

@Nov11 Nov11 commented Mar 8, 2019

deal with situations that index overflows and returns negative value. this leads to IndexOutOfBoundException

@update-changelog
Copy link

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the CHANGELOG.md file with this pull request.

@coveralls
Copy link

coveralls commented Mar 8, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 4025

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 49.391%
Totals Coverage Status
Change from base Build 4022: 0.04%
Covered Lines: 11886
Relevant Lines: 24065
💛 - Coveralls

@davidjgonzalez davidjgonzalez self-requested a review March 15, 2019 17:07
@davidjgonzalez davidjgonzalez added this to the 4.0.2 milestone Mar 15, 2019
davidjgonzalez
davidjgonzalez requested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@davidjgonzalez davidjgonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a Unit Test as well as a changelog.md entry please?

@Nov11
Copy link
Contributor Author

Nov11 commented Mar 18, 2019 •
edited
Loading

Unit Tests and an entry in change log have bean added.

@davidjgonzalez

badvision
badvision approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@badvision badvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@badvision badvision merged commit 22ac5cf into Adobe-Consulting-Services:master Mar 22, 2019
@justinedelson justinedelson modified the milestones: 4.0.2, 4.1.0 May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjgonzalez davidjgonzalez davidjgonzalez requested changes

@badvision badvision badvision approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Nov11 @coveralls @davidjgonzalez @badvision @justinedelson