Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #1699 #1702

Merged
merged 4 commits into from
Jan 17, 2019
Merged

Fix for #1699 #1702

merged 4 commits into from
Jan 17, 2019

Conversation

badvision
Copy link
Contributor

Updated JSON serialization logic in the MCP servlet to be more explicit about what to exclude

@coveralls
Copy link

coveralls commented Jan 17, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 3760

  • 9 of 16 (56.25%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 48.914%
Changes Missing Coverage Covered Lines Changed/Added Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/ControlledProcessManagerServlet.java 9 16 56.25%
Files with Coverage Reduction New Missed Lines %
bundle/src/main/java/com/adobe/acs/commons/mcp/impl/ControlledProcessManagerServlet.java 1 28.24%
Totals Coverage Status
Change from base Build 3752: 0.09%
Covered Lines: 11617
Relevant Lines: 23750
💛 - Coveralls

@badvision badvision merged commit 84c743b into master Jan 17, 2019
@badvision badvision deleted the feature/1699-fix-json-serialization branch January 17, 2019 19:54
@badvision badvision added this to the 4.0.0 milestone Jan 17, 2019
justinedelson pushed a commit that referenced this pull request Feb 6, 2019
@badvision @justinedelson
Fix for #1699 (#1702)
9233c56 
* Fix for #1699

* Added test coverage and also improved handling of multi-value parameters as arrays of strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@badvision @coveralls