Feature/action manager priority queue #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bsequent classes, resulting in the throttled task runner using a priorityBlockingQueue to implement the prioritization
the joys of mockity any
… to the ThreadPoolExecutor to use a custom one that respects priority even when the task gets deferred.
badvision
reviewed
Oct 26, 2018
| String fullName = String.format("%s (%s)", name, UUID.randomUUID().toString()); | ||
|
|
||
| ActionManagerImpl manager = new ActionManagerImpl(fullName, taskRunner, resourceResolver, saveInterval); | ||
| ActionManagerImpl manager = new ActionManagerImpl(fullName, taskRunner, resourceResolver, saveInterval, priroty); |
There was a problem hiding this comment.
This is exactly the sort of high quality code review I expect.
Snark aside, will fix this, thanks for pointing it out.
There was a problem hiding this comment.
Hey, it's open-source. You're getting so much more than you paid for already! ;P But seriously, thanks for the awesome PR!
badvision
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is mostly self explanatory. By adding an optional parameter to the action manager for the priority, we can give tasks a priority and order their execution based on this priority.
While this does not exactly guarantee the order of execution (could vary depending on how long various tasks take), it does allow you to order tasks that are more important first. For example, you may want to execute more resource intensive tasks first to free up those resources for other things.