Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open MCP item dialog in Firefox #2058

Closed
3 tasks
gutsy opened this issue Sep 26, 2019 · 3 comments
Closed
3 tasks

Cannot open MCP item dialog in Firefox #2058

gutsy opened this issue Sep 26, 2019 · 3 comments
Milestone

Comments

@gutsy
Copy link
Contributor

gutsy commented Sep 26, 2019

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.5___
  • ACS AEM Commons Version: 4.1.0_
  • Reproducible on Latest? yes

Expected Behavior

MCP task list should show and be clicked to get dialog with options to view report or download.

Actual Behavior

During initial load of content, this error occurs in the console:
XML Parsing Error: syntax error
Location: http://localhost:4502/etc/acs-commons/manage-controlled-processes/jcr:content.list.json
Line Number 1, Column 1:

When clicking on an item to open the dialog, this error occurs and no dialog opens:
TypeError: this._syncProp is not a function
TypeError: diag.show is not a function

Steps to Reproduce

Open MCP tools and run a process if you have nothing in the list. After it's run, try to open the item from the list.

@badvision
Copy link
Contributor

Very bizarre. In the client lib code that creates the dialog, the object is correctly defined. Then it is added to the DOM of the document. After that command is processed, the object is downgraded to an HTML element and the show() method isn't available because the prototype is no longer the Coral.Dialog. Because of this, it throws an error that show() is not a declared method. I suspect this is mostly a firefox bug but I can't for the life of me figure out how to get around it except to not append the element to the DOM in firefox.

@badvision
Copy link
Contributor

Seems that removing the line of code that inserts the Dialog into the DOM is sufficient to fix this in firefox and doesn't appear to affect Chrome.

@badvision
Copy link
Contributor

No idea about that xml error. Seems benign.

badvision added a commit that referenced this issue Sep 27, 2019
* #2058 - Addresses issues with firefox in MCP

* #2057 - Force height to 100% on outer div so it doesn't disappear in the new version of chrome.
@badvision badvision added this to the 4.3.4 milestone Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants