Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog resource provider should support components too #1993

Closed
2 tasks done
badvision opened this issue Jul 18, 2019 · 0 comments
Closed
2 tasks done

Dialog resource provider should support components too #1993

badvision opened this issue Jul 18, 2019 · 0 comments
Assignees
@badvision
Labels
bug pinned
Milestone
4.3.0

Comments

@badvision
Copy link
Contributor

Required Information

  • ACS AEM Commons Version: 4.2.0
  • Reproducible on Latest? yes

Expected Behavior

The generated dialog produces a facsimile of the structure of pages' cq:dialogs but not components. It is much more likely that this will be used with components in the future and therefore those should be supported (and also made the default behavior!)

Actual Behavior

Dialog is generated for a component but it doesn't work correctly, it's missing the dialog wrapper markup.
@badvision badvision added this to the 4.2.4 milestone Jul 18, 2019
@badvision badvision self-assigned this Jul 18, 2019
badvision added a commit that referenced this issue Jul 22, 2019
@badvision
Added style control for dialogs via the DialogProvider annotation. (#…
9796919 
…1993) (#1994)

* Added style control for dialogs via the DialogProvider annotation.  Also added components for RTE and autocomplete

* Added logic to force dot-slash prefix on form element names, which is on by default but can also be disabled on a form if needed.
@badvision badvision modified the milestones: 4.2.4, 4.3.0 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@badvision badvision

Labels
bug pinned
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
1 participant
@badvision