Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect map entry cannot be edited #1981

Closed
3 tasks
FireFoxG opened this issue Jul 9, 2019 · 2 comments
Closed
3 tasks

Redirect map entry cannot be edited #1981

FireFoxG opened this issue Jul 9, 2019 · 2 comments
Assignees
Milestone

Comments

@FireFoxG
Copy link

FireFoxG commented Jul 9, 2019

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: 6.4.2
  • ACS AEM Commons Version: 4.0.0
  • Reproducible on Latest? yes

Expected Behavior

Bug appears inside Redirect Map, Edit Entries tab, in "View Entries" list
When clicking Edit button on an entry, which is coming from some page (not from file). Then this page should open in editor mode.

Actual Behavior

Instead JS error in console appears:

TypeError: path.indexOf is not a function
at a.$$childScopeClass.$$childScopeClass.$scope.openEditor (clientlibs.js:131)
at all.js:177
at f (all.js:194)
at a.$$childScopeClass.$$childScopeClass.$eval (all.js:112)
at a.$$childScopeClass.$$childScopeClass.$apply (all.js:112)
at HTMLButtonElement. (all.js:194)
at HTMLButtonElement.dispatch (jquery.js:5226)
at HTMLButtonElement.elemData.handle (jquery.js:4878)

Happens due to the wrong parameter that is passed inside content.jsp

ng-click="openEditor(entry.id)"

Should probably use entry.origin instead.

@davidjgonzalez
Copy link
Contributor

@FireFoxG any chance you can PR a fix?

@davidjgonzalez davidjgonzalez added this to the 4.2.4 milestone Jul 16, 2019
badvision pushed a commit that referenced this issue Jul 22, 2019
…d Assets (#1985)

* Fixing #1981 -- Fixing where the edit button didn't work for pages and assets
@badvision
Copy link
Contributor

@klcodanr are we ok to close this issue now that the PR is merged?

@badvision badvision modified the milestones: 4.2.4, 4.3.0 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants