Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Workflow MCP Process #1953

Closed
davidjgonzalez opened this issue Jun 13, 2019 · 3 comments
Closed

Bulk Workflow MCP Process #1953

davidjgonzalez opened this issue Jun 13, 2019 · 3 comments
Assignees
@davidjgonzalez
Labels
feature review
Milestone
4.3.0

Comments

@davidjgonzalez
Copy link
Contributor

It would be nice to move Bulk Workflow Manager to MCP Process. This would mean Bulk Workflow would only support Synthetic Workflow (multi-threaded).

This will help clear out /etc/acs-commons and reduce the need to re-creating BWM on something more modern than AngularJS. Also, worth noting per #1951 BWM running AEM Workflow on 6.5 breaks (appears to result in . a number of Oak conflicts as the WF runs on the payloads)

This UI would simplify the execution options to be:

  • Query language (querybuilder, list, jcq-sql2, xpath, jcr-sql)
  • Query statement
  • Relative path
  • Workflow model

.. Something like ..

image
@davidjgonzalez davidjgonzalez self-assigned this Jun 13, 2019
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Jun 13, 2019
@davidjgonzalez
Adobe-Consulting-Services#1953 - Create Bulk Workflow MPC process
16e9539
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Jun 13, 2019
@davidjgonzalez
Adobe-Consulting-Services#1953 - Fix bug in QueryHelperImpl where rel…
5020498 
…ative path param is not respected for QueryBuilder query language type
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Jun 13, 2019
@davidjgonzalez
Adobe-Consulting-Services#1953 - changelog
8a09a2f
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Jun 13, 2019
@davidjgonzalez
Adobe-Consulting-Services#1953 - codeclimate
7be501e
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Jun 19, 2019
@davidjgonzalez
Adobe-Consulting-Services#1953 - fixes
8a05d96
@badvision
Copy link
Contributor

One thing I've never been hip to was requiring a user to enter a query as text, but for a first pass that's fine. Are there any other considerations we should make? For example, we might want to consider adding reporting options (detailed vs. counts only) and a dry run option so that it's feature-parity with some of the more powerful MCP tools like Renovator.

@davidjgonzalez
Copy link
Contributor Author

Sure you can add those features in later PR is you want. This was trying to achieve functional parity w BWM so we can start deprecating it.

A dry run flag should be pretty easy for you to add.

This feature may be moot soon anyhow so I’d think about that before investing too much time in it tho!

@badvision badvision added this to the 4.2.4 milestone Jul 22, 2019
@badvision
Copy link
Contributor

Sounds good! Looks like we have this merged in already so I'll close this issue.

davidjgonzalez added a commit that referenced this issue Jul 31, 2019
@davidjgonzalez
Feature/1953 - Bulk Workflow MCP Process (#1996)
29918c6 
* #1953 - Bulk Workflow MPC process
@badvision badvision modified the milestones: 4.2.4, 4.3.0 Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidjgonzalez davidjgonzalez

Labels
feature review
Projects
None yet
Milestone
4.3.0
Development

No branches or pull requests
2 participants
@davidjgonzalez @badvision