Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow removed removing workflow instances newer than passed date #1528

Closed
3 tasks
tb7032 opened this issue Oct 30, 2018 · 5 comments
Closed
3 tasks

Workflow removed removing workflow instances newer than passed date #1528

tb7032 opened this issue Oct 30, 2018 · 5 comments
Assignees
Milestone

Comments

@tb7032
Copy link

tb7032 commented Oct 30, 2018

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: AEM 6.3 / AEM 6.4__
  • ACS AEM Commons Version: 3.17_
  • Reproducible on Latest? yes

### Expected Behavior

Workflow remover should respect the 'Workflows older than' argument when deleting running workflow instances.

### Actual Behavior

Workflow instances newer than the passed date appear to get deleted.

### Steps to Reproduce

  • Start clean AEM 6.3 / 6.4
  • Install latest ACS Commons
  • Start a couple of workflows that will stay in running state - ie a couple of Request For Activation worklfows (against any pages or assets).
  • Confirm that the workflows are visible and showing as running in the workflow console
  • Open workflow remover and select to remove:
    ** Status: Running
    ** Workflows older than: any date before the date the workflows started above (ie 72 hours ago
  • Click 'Remove Workflows'
  • Refresh workflow console and notice that the workflows started above were removed, despite apparently not meeting the passed criteria.

Links

n/a

@stale
Copy link

stale bot commented Dec 29, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 29, 2018
@stale stale bot closed this as completed Jan 6, 2019
@vaibhav26sharma
Copy link

@davidjgonzalez @justinedelson I am also facing this. Can you please help here? All the workflow instances get removed without respecting Workflows older than criteria.

@vaibhav26sharma
Copy link

@davidjgonzalez In the meantime, can you please point me to the code so that I can debug and try to add an intermediate fix?

@pa-stef
Copy link

pa-stef commented Mar 18, 2019

I, also get this bug.
I guess the problem is here
https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/acs-aem-commons-3.19.0/bundle/src/main/java/com/adobe/acs/commons/workflow/bulk/removal/impl/WorkflowInstanceRemoverImpl.java****
line 279
final Calendar startTime = properties.get(PN_STARTED_AT, Calendar.class);
PN_STARTED_AT has to be startTime

davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Mar 19, 2019
@davidjgonzalez
Copy link
Contributor

This should be fixed via: #1793

@davidjgonzalez davidjgonzalez self-assigned this Mar 19, 2019
@davidjgonzalez davidjgonzalez added this to the 4.0.2 milestone Mar 19, 2019
davidjgonzalez added a commit to davidjgonzalez/acs-aem-commons that referenced this issue Mar 22, 2019
@justinedelson justinedelson modified the milestones: 4.0.2, 4.1.2 May 7, 2019
@davidjgonzalez davidjgonzalez modified the milestones: 4.1.2, 4.2.2 Jun 19, 2019
@davidjgonzalez davidjgonzalez modified the milestones: 4.2.2, 4.2.4 Jul 16, 2019
@badvision badvision modified the milestones: 4.2.4, 4.3.2 Aug 1, 2019
@justinedelson justinedelson modified the milestones: 4.3.2, 4.3.4 Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants