Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorfield can not work well on multifield #1462

Closed
3 tasks done
xuanuy opened this issue Aug 18, 2018 · 4 comments
Closed
3 tasks done

colorfield can not work well on multifield #1462

xuanuy opened this issue Aug 18, 2018 · 4 comments
Milestone

Comments

@xuanuy
Copy link
Contributor

xuanuy commented Aug 18, 2018

Required Information

  • AEM Version, including Service Packs, Cumulative Fix Packs, etc: Adobe Experience Manager (6.3.2.2)
  • ACS AEM Commons Version: acs-aem-commons-content-3.17.0
  • Reproducible on Latest? yes

Expected Behavior

granite/ui/components/coral/foundation/form/colorfield should be load in granite/ui/components/foundation/form/multifield correctly.

Actual Behavior

granite/ui/components/coral/foundation/form/colorfield doesn't load correct in granite/ui/components/foundation/form/multifield

Steps to Reproduce

Use granite/ui/components/coral/foundation/form/colorfield in granite/ui/components/foundation/form/multifield, config to save value as json.
Can save value when submit dialog but when re-open dialog the value of colorfield is not loaded correctly.

Links

@xuanuy
Copy link
Contributor Author

xuanuy commented Aug 18, 2018

Modified touchui-widgets-init.js to fix.
touchui-widgets-init.js.zip

@justinedelson
Copy link
Contributor

@xuanuy can you submit this as an actual pull request?

xuanuy added a commit to xuanuy/acs-aem-commons that referenced this issue Aug 19, 2018
xuanuy added a commit to xuanuy/acs-aem-commons that referenced this issue Aug 30, 2018
@xuanuy
Copy link
Contributor Author

xuanuy commented Aug 30, 2018

@justinedelson i've fixed issue. Could you verify?

davidjgonzalez pushed a commit that referenced this issue Sep 26, 2018
* colorfield can not work well on multifield (#1462)
davidjgonzalez added a commit that referenced this issue Sep 26, 2018
@davidjgonzalez davidjgonzalez added this to the 3.18.2 milestone Sep 26, 2018
@badvision badvision modified the milestones: 3.18.2, 3.19.0 Oct 9, 2018
@jeffreyniu
Copy link

do you add this hotfix to package 3.18.2 or 3.19.0? i tried these 2 packages, but i found it was not be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants