-
-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed auto-cpufreq error installation #709
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the comments I made.
@@ -125,12 +126,21 @@ function tool_install { | |||
|
|||
header "Installing necessary Python packages" | |||
|
|||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to merge this like this, it seems like you were in process of resolving a git commit?
python3.10 -m venv "${venv_dir}" | ||
|
||
source "${venv_dir}/bin/activate" | ||
python3.10 -m pip install --upgrade pip wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would you want to limit it to 3.10 in particular, especially since latest version is 3.12 when otherwise it'll just use latest version?
venv_dir=$VENV_PATH/venv | ||
mkdir -p "$venv_dir" | ||
python3 -m venv "$venv_dir" | ||
|
||
source "$venv_dir/bin/activate" | ||
python3 -m pip install --upgrade pip wheel | ||
>>>>>>> 420648f5f12f6e5a486e71a4284b898a29f32459 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said above don't think these lines should be here ...
Closed due to inactivity. |
This error was encountered when the python was lower than 3.10.
You need to install multiple python in /usr/bin/python3.10 where the default /usr/bin/python3.8 exists.