Filters and evo #407
Open
Filters and evo #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Filtering for EC % 100 (Dudunsparce), added Wurmple evolutions to the output (working on making it ONLY show for Wurmple), and added height and weight to Egg Output (still need correct rng calls for them)
Added Filtering for EC % 100 (Dudunsparce), added Wurmple evolutions to the output (working on making it ONLY show for Wurmple), and added height and weight to Egg Output (still need correct rng calls for them)
Removed height and weight for now
Height filtering added for modules that support it, hid filters from unsupported modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for filtering evolution forms based on the Encryption Constant (currently only relevant for Dunsparce), and added a new column at the end of the results called "Extra Info" that provides, well, extra info about the Pokemon at that advance. For now, all it can display is Silcoon or Cascoon for Wurmples, Three-Segment for Dunsparce, or None for anything else.
TODO: Mark-only Sizes checkbox is still there but non-functional (Didn't feel like editing the UI again, tbh). Also, the new checkboxes appear to show up on ALL PokeFinder Gens, not just Gen 8 Eggs (which is what I'm making these additions for). I know its possible to hide UI elements on certain sections of PokeFinder (I see an Encounter Slot option when Wild is open) but I couldn't figure out how to do it yet.
Edit 2: Fixed this a while ago but forgot to mention. Should be perfect for release now.