Skip to content

Conversation

MightyMCoder
Copy link
Member

see Forum

Copy link
Member

@Fasse Fasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it's the wrong place to handle the empty array in the call script of getQmForValues. I think we should improve the getQmForValues function to better handle empty arrays because in that case the current output is always wrong. So we should check if the array is empty and then we should check if its an integer or string array and depending on this add the default entry.

@MightyMCoder
Copy link
Member Author

In my opinion it's the wrong place to handle the empty array in the call script of getQmForValues. I think we should improve the getQmForValues function to better handle empty arrays because in that case the current output is always wrong. So we should check if the array is empty and then we should check if its an integer or string array and depending on this add the default entry.

That's a good idea. I didn't thought about that in this way and only looked for similar usages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants