This repository was archived by the owner on Jul 24, 2023. It is now read-only.
Start the process to support Laravel 7 #853
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the tests except for
DatabaseProviderTest::auth_attempts_fallback_using_config_option
work and I've resolved the warnings around@expectedException
annotations. I can't quite tell what's going on. I think it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.This would close #852 and probably mean a new version? Again, some direction would be helpful if you want some help on it. I've set the
adldap2/adldap2
dependency to bedev-master
because I saw you did some work on supporting 7 today.Let me know!