Skip to content
This repository was archived by the owner on Jul 24, 2023. It is now read-only.

Start the process to support Laravel 7 #853

Closed
wants to merge 1 commit into from

Conversation

grantholle
Copy link

All the tests except for DatabaseProviderTest::auth_attempts_fallback_using_config_option work and I've resolved the warnings around @expectedException annotations. I can't quite tell what's going on. I think it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.

This would close #852 and probably mean a new version? Again, some direction would be helpful if you want some help on it. I've set the adldap2/adldap2 dependency to be dev-master because I saw you did some work on supporting 7 today.

Let me know!

All the tests except for `DatabaseProviderTest::auth_attempts_fallback_using_config_option` work and I've resolved the warnings around `@expectedException` annotations. I can't quite tell what's going on. I _think_ it's because AdLdap2 is throwing exceptions when before it only returned null or something? I wouldn't mind taking it on, but could use some direction on how you want to handle it.
@rimace
Copy link

rimace commented Mar 5, 2020

Laravel 6.0 is an LTS version. It would be nice if the LTS version would still be supported.

@grantholle
Copy link
Author

Yeah I agree supporting 6 would be ideal as well. orchestra/testbench v5 supports 7 but not 6. I don't know if that would hold it back from supporting both versions of Laravel?

@stevebauman
Copy link
Member

@rimace There should be no issues supporting Laravel 5.5 and greater (up to Laravel 7.0).

@stevebauman
Copy link
Member

stevebauman commented Mar 5, 2020

Can't merge this due to requiring dev-master. I need to finish cleaning some things in the core Adldap2 package and make a new release so Laravel 7.0 is supported properly.

@stevebauman stevebauman closed this Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Laravel 7
3 participants