-
Couldn't load subscription status.
- Fork 112
Unified Codebase for Retail, Classic, and TBC #648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… on. Fixed bank Constants for Classic.
Removed Reagent bank slots event registration for Classic.
…ility. Also, they're constants :p
|
If you have no comments, I'm going to merge this so I can get started on the current open issues. Unrelated, but thanks with the help triaging the older issues that needed to be resurfaced @Talyrius :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than some whitespace nitpicks (unimportant as the rest of the codebase is inconsistent as it is), nothing stands out to me. I haven't yet reactivated my sub to test drive it, but you said you had already done so anyway. Looks good! 👍
|
Awesome, I'll merge this later tonight! re: Whitespace, I'm thinking about adding some linting rules to fix this in general. I'll revisit it. |
This CL resolves #646 and fully unifies the codebase for all three versions of World of Warcraft on the market. It works by adding 4 new constants to Constants.lua that can determine the running version at runtime. These constants are then used to conditionally branch various parts of the code so AdiBags works across all three releases from a single codebase.
This CL also adds support for building all three versions via BigWigsMods packager under a single git tag. At any point after this CL, simply upload a new tag and the Github action tied to this repo will build the correct artifacts for each version of WoW.
Things to note:
I've tested on retail, classic, and classic era:
I've encountered no obvious bugs. @Talyrius Can you do a quick lookover and see if this looks good? I know you're not around much, which is fine -- if I don't hear from you by sometime next week, I'll go ahead and merge this.
Thanks!