Exception rules interfere with each other

[jellizaveta]

There are two rules in the Basic Filter (from EL) that don't work together:

@@||www.google.*/search?$generichide

@@||www.google.*/search?$domain=google.ae|google.at|google.be|google.bg|google.by|google.ca|google.ch|google.cl|google.co.id|google.co.il|google.co.in|google.co.jp|google.co.ke|google.co.kr|google. co.nz|google.co.th|google.co.uk|google.co.ve|google.co.za|google.com|google.com.ar|google.com.au|google.com.br|google.com.co|google.com.ec|google.com.eg|google.com.hk|google.com.mx|google.com my|google.com.pe|google.com.ph|google.com.pk|google.com.py|google.com.sa|google.com.sg|google.com.tr|google.com.tw|google.com.ua|google.com.uy|google.com.vn|google.cz|google.de|google.dk|google. dz|google.ee|google.es|google.fi|google.fr|google.gr|google.hr|google.hu|google.it|google.lt|google.lv|google.nl|google.no|google.pl|google.pt|google.ro|google.rs|google.ru|google.se|google.sk

because of this rule : ~hatena.ne.jp##a[href*="//b.hatena.ne.jp/entry/"] links in google search results are hidden.

Screenshot:

https://www.google.com/search?q=inurl%3Ab.hatena.ne.jp%2Fentry

Expected behavior: links are not hidden

Screenshot:

When I disable one of the rules, the links appear.

[ameshkov]

Do we have the same issue in CoreLibs?

[jellizaveta]

AdguardTeam/CoreLibs#1749 - yep, created

[ameshkov]

In tsurlfilter there's a simple rule of calculating rules priorities: the more "specific" the rule is, the higher the priority is:

tsurlfilter/packages/tsurlfilter/src/rules/network-rule.ts

Line 825 in 28a0115

isHigherPriority(r: NetworkRule): boolean {

We already have logic for higher priority of document-level rules:
https://github.com/AdguardTeam/tsurlfilter/blob/master/packages/tsurlfilter/src/rules/network-rule.ts#L763

However, missed generichide / genericblock there.

[105th]

@jellizaveta looks like it was fixed with new priority schema. i checked in 4.2.249 - links are visible

If not fixed, please reopen.