Exception rules interfere with each other

[jellizaveta]

There are two rules in the Basic Filter (from EL) that don't work together:

@@||www.google.*/search?$generichide

@@||www.google.*/search?$domain=google.ae|google.at|google.be|google.bg|google.by|google.ca|google.ch|google.cl|google.co.id|google.co.il|google.co.in|google.co.jp|google.co.ke|google.co.kr|google. co.nz|google.co.th|google.co.uk|google.co.ve|google.co.za|google.com|google.com.ar|google.com.au|google.com.br|google.com.co|google.com.ec|google.com.eg|google.com.hk|google.com.mx|google.com my|google.com.pe|google.com.ph|google.com.pk|google.com.py|google.com.sa|google.com.sg|google.com.tr|google.com.tw|google.com.ua|google.com.uy|google.com.vn|google.cz|google.de|google.dk|google. dz|google.ee|google.es|google.fi|google.fr|google.gr|google.hr|google.hu|google.it|google.lt|google.lv|google.nl|google.no|google.pl|google.pt|google.ro|google.rs|google.ru|google.se|google.sk

because of this rule : ~hatena.ne.jp##a[href*="//b.hatena.ne.jp/entry/"] links in google search results are hidden.

Screenshot:

https://www.google.com/search?q=inurl%3Ab.hatena.ne.jp%2Fentry

Expected behavior: links are not hidden

Screenshot:

When I disable one of the rules, the links appear.

AdguardTeam/tsurlfilter#82

Exceptions have been added to the Social Media filter, pay attention to this when checking. AdguardTeam/AdguardFilters@7d05d51

[ameshkov]

Please see the discussion in that issue:
AdguardTeam/tsurlfilter#82 (comment)

[ngorskikh]

@ameshkov In corelibs, we consider "exception rules with modifiers" the lowest priority, and even have tests that test for that. It looks like the behaviour in the OP is correct. Furthermore, even if we were to shuffle priorities around, then it would only mean that the other rule from the OP would stop working and would become useless altogether. What if instead we started applying some rules (like generichide here) regardless if they are the first match from the urlfilter?

[ameshkov]

@ngorskikh I am not sure where this logic comes from, in theory the more specific the rule, the higher the priority should be.