Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'href-sanitizer' — add base64 support #455

Closed
billkewl opened this issue Sep 24, 2024 · 2 comments
Closed

Improve 'href-sanitizer' — add base64 support #455

billkewl opened this issue Sep 24, 2024 · 2 comments
Assignees
@jellizaveta
Labels
enhancement Improvement of existent feature Priority: P4 Release: v2.0.1 Resolution: Fixed Status: Closed Version: Scriptlets v2.0

Comments

@billkewl
Copy link

Someone websites hide the actual urls behind base64 encoded string. Currently 'href-sanitizer' can't handle this correctly.
It would be best if there's a base64 option for 'href-sanitizer' scriptlet

Related issue (Firefox skip redirect extension) sblask-webextensions/webextension-skip-redirect#181
@billkewl
Copy link
Author

billkewl commented Sep 25, 2024 •
edited
Loading

It'd be best if href's attributes can be modified at the same time.

For example, every video link in youtube search result page has a parameter "pp=[base64 encoded search query]" in it and it can't be got rid of with current options.
Can we have another option for text and ?parameter to remove parameters in href, like $removeparam considering YouTube can add more private info in it. Sharing raw links from right click copy also exposes how the sharer found the video. $removeparam can only remove parameters after clicking on the link.

Other websites might shove in unnecessary, often tracking parameters as well. So I would like to see a combination of removeparam and href-santinizer

@adguard-bot adguard-bot changed the title Improve 'href-sanitizer' with base64 support Improve 'href-sanitizer' — add base64 support Sep 27, 2024
@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Sep 27, 2024
@adguard-bot adguard-bot assigned jellizaveta and unassigned maximtop Oct 7, 2024
adguard pushed a commit that referenced this issue Oct 11, 2024
@jellizaveta
AG-36282 Add 'transform' option with 'base64decode' value for 'href-s…
c81eeb6 
…anitizer' scriptlet. #455
@slavaleleka slavaleleka mentioned this issue Oct 15, 2024
Closed
@slavaleleka
Copy link
Contributor

@billkewl thanks for the suggestion!

I've made a separate task for it:
#460

adguard pushed a commit that referenced this issue Oct 16, 2024
@jellizaveta
AG-36282 Add 'transform' option with 'base64decode' value for 'href-s…
1de3e88 
…anitizer' scriptlet

Squashed commit of the following:

commit 66df93f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Oct 16 13:10:27 2024 +0300

    fix description, update script

commit 8d6f7f0
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Oct 15 21:22:36 2024 +0300

    simplify code, add constant

commit 6f6d257
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Oct 15 20:21:22 2024 +0300

    fix name, comment, simplify code

commit cd29a52
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Oct 15 19:50:38 2024 +0300

    src/scriptlets/href-sanitizer.ts edited online with Bitbucket

commit 6656964
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Oct 15 19:50:31 2024 +0300

    src/scriptlets/href-sanitizer.ts edited online with Bitbucket

commit cc14769
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Oct 15 19:50:26 2024 +0300

    src/scriptlets/href-sanitizer.ts edited online with Bitbucket

commit 82ee60f
Merge: ffcfd67 901cb2e
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Oct 15 16:13:54 2024 +0300

    merge master

commit ffcfd67
Merge: 83ee0aa dac16b7
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Oct 14 17:08:24 2024 +0300

    resolve conflicts

commit 83ee0aa
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Oct 14 17:03:26 2024 +0300

    add the ability to decode base64 string multiple times, fix typo, decode search params, add tests

commit 436985f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Oct 14 13:19:25 2024 +0300

    fix typo

commit 5eb91b9
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Oct 11 21:40:00 2024 +0300

    fix indent in docs

commit f8384c6
Merge: c81eeb6 0ca98f3
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Oct 11 20:18:16 2024 +0300

    merge master

commit c81eeb6
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Oct 11 20:08:58 2024 +0300

    AG-36282 Add 'transform' option with 'base64decode'  value for 'href-sanitizer' scriptlet. #455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jellizaveta jellizaveta

Labels
enhancement Improvement of existent feature Priority: P4 Release: v2.0.1 Resolution: Fixed Status: Closed Version: Scriptlets v2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximtop @adguard-bot @slavaleleka @jellizaveta @billkewl