Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging in scriptlets #411

Closed
AdamWr opened this issue Mar 15, 2024 · 0 comments
Closed

Improve logging in scriptlets #411

AdamWr opened this issue Mar 15, 2024 · 0 comments
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.6 Resolution: Fixed Status: Closed Version: Scriptlets v1.11

Comments

@AdamWr
Copy link
Member

AdamWr commented Mar 15, 2024 •
edited
Loading

In some scriptlets which replace content (like xml-prune, m3u-prune, trusted-replace-fetch-response, trusted-replace-node-text, trusted-replace-xhr-response, maybe in others too) it would be useful if there would be additional option to log content before and after modifying it.
It would be helpful for debugging and creating rules.

Maybe related to - #305
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop Jun 4, 2024
adguard pushed a commit that referenced this issue Jun 25, 2024
@AdamWr
AG-31162 Improve logging in scriptlets. #411
5614b1e 
Squashed commit of the following:

commit ce58a21
Author: Adam Wróblewski <adam@adguard.com>
Date:   Mon Jun 24 17:01:24 2024 +0200

    Change `logContent` to `verbose`
    Update docs

commit c2503ef
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Jun 18 11:46:12 2024 +0200

    Fix docs build

commit bdea52f
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Jun 18 09:41:24 2024 +0200

    Update docs

commit a17278d
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 13:29:09 2024 +0200

    Update changelog

commit be4e0a8
Merge: a80d212 a2ac480
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 13:21:43 2024 +0200

    Merge branch 'master' into fix/AG-31162

commit a80d212
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 13:19:50 2024 +0200

    Add ability to log original and modified M3U content in m3u-prune scriptlet

commit 59d1348
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 13:00:21 2024 +0200

    Add ability to log original and modified XML content in xml-prune scriptlet

commit ee3c9c9
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 12:01:47 2024 +0200

    Add ability to log original and modified text content in trusted-replace-xhr-response scriptlet

commit 8a02970
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 11:49:08 2024 +0200

    Add ability to log original and modified text content in trusted-replace-fetch-response scriptlet

commit 84e0757
Author: Adam Wróblewski <adam@adguard.com>
Date:   Fri Jun 14 11:25:16 2024 +0200

    Add ability to log original and modified text content in trusted-replace-node-text scriptlet
This was referenced Aug 2, 2024
Open
Open
Closed
@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.6 Resolution: Fixed Status: Closed Version: Scriptlets v1.11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@maximtop @AdamWr @adguard-bot @slavaleleka