-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'xml-prune' — support xpath for text content matching #325
Labels
enhancement
Improvement of existent feature
Feature request
Adding new feature
Priority: P4
Release: v1.9.70
Resolution: Fixed
Status: Closed
Version: Scriptlets v1.9
Comments
This was referenced Jun 8, 2023
slavaleleka
added
enhancement
Improvement of existent feature
and removed
Feature request
Adding new feature
labels
Jun 8, 2023
adguard-bot
changed the title
Improve 'xml-prune' scriptlet
Improve 'xml-prune' — match text content
Jun 8, 2023
uBO supports xpath and it turend out to be useful to address Prime video ads where |
adguard-bot
changed the title
Improve 'xml-prune' — match text content
Improve 'xml-prune' — support xpath for text content matching
Jul 24, 2023
adguard-bot
added
Status: In Progress
Resolution: Fixed
Status: In Review
Status: Resolved
and removed
Status: In Progress
Status: In Review
labels
Aug 16, 2023
adguard
pushed a commit
that referenced
this issue
Aug 18, 2023
#325 Squashed commit of the following: commit 7bc2b75 Author: Adam Wróblewski <adam@adguard.com> Date: Thu Aug 17 12:52:55 2023 +0200 Change variable name Avoid unnecessary nesting commit bf846a7 Author: Adam Wróblewski <adam@adguard.com> Date: Wed Aug 16 12:49:29 2023 +0200 Add JSDoc Rename xPathElements to getXPathElements commit 0f4588e Author: Slava Leleka <v.leleka@adguard.com> Date: Wed Aug 16 13:18:06 2023 +0300 Update description commit 70805ad Author: Slava Leleka <v.leleka@adguard.com> Date: Wed Aug 16 13:17:55 2023 +0300 Update description commit 821003e Merge: b3d8355 9b71be1 Author: Adam Wróblewski <adam@adguard.com> Date: Wed Aug 16 09:03:11 2023 +0200 Merge branch 'master' into feature/AG-22975 commit b3d8355 Author: Adam Wróblewski <adam@adguard.com> Date: Wed Aug 16 08:56:42 2023 +0200 Add support for XPath in xml-prune
adguard-bot
added
Version: Scriptlets v1.9
Release: v1.9.70
and removed
Version: Scriptlets v1.10
labels
Sep 4, 2023
This was referenced Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improvement of existent feature
Feature request
Adding new feature
Priority: P4
Release: v1.9.70
Resolution: Fixed
Status: Closed
Version: Scriptlets v1.9
Problem
It is impossible to select an element that contains certain text.
Example:
Ads on
https://pluto.tv/en/on-demand/movies/6111bbe29b91f300138dc5d9
Ad config is stored here in the
.MPD
file:https://gist.githubusercontent.com/Alex-302/b8c23ece5fbe1c80deb4efa8af96c51d/raw/8592abecef9398c28033d093f8999c987e6d3499/pluto.mdp
In this case following element contain info about video ad:
Details
and it may be matched by
_ad/creative/
.Proposed solution
Add ability to match element, which contains a text, including using regexp (like
:contains()
in Extended CSS).It is desirable to use a syntax simpler than XPatch
//Period[contains(BaseURL, '_ad/creative/')]
, like in ExtCSS or better like/similar to$jsonprune
of CoreLibs.The text was updated successfully, but these errors were encountered: