Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'trusted-click-element' — add 'reload' option #301

Closed
zloyden opened this issue Mar 28, 2023 · 0 comments
Closed

Improve 'trusted-click-element' — add 'reload' option #301

zloyden opened this issue Mar 28, 2023 · 0 comments
Assignees
@jellizaveta
Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.27 Resolution: Fixed Status: Closed Version: Scriptlets v1.11

Comments

@zloyden
Copy link

zloyden commented Mar 28, 2023

Please consider adding a reload option to the trusted-click-element scriptlet. I assume this is not the last case and it would be wonderful to avoid using JS rules for this.
@zloyden zloyden added the enhancement Improvement of existent feature label Mar 28, 2023
@zloyden zloyden changed the title 'trusted-click-element' - reload option trusted-click-element - reload option Mar 28, 2023
@zloyden zloyden mentioned this issue Mar 28, 2023
Merged
@adguard-bot adguard-bot changed the title trusted-click-element - reload option Improve 'trusted-click-element' — add 'reload' option Jul 18, 2023
@jellizaveta jellizaveta mentioned this issue Feb 19, 2024
Closed
adguard pushed a commit that referenced this issue Aug 16, 2024
@jellizaveta
Improve 'trusted-click-element' — add 'reload' option. #301
19c73a7
adguard pushed a commit that referenced this issue Aug 21, 2024
@jellizaveta
AG-20872 Improve 'trusted-click-element' — add 'reload' option. #301
73ee393 
Squashed commit of the following:

commit 432279a
Merge: 8f43a26 48ba492
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 21:04:08 2024 +0300

    Merge branch 'master' into fix/AG-20872

commit 8f43a26
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 16:11:45 2024 +0300

    replace the use of regexp

commit d421ce8
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 13:56:32 2024 +0300

    fix typo

commit 6f90958
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 13:41:44 2024 +0300

    update description

commit ef4855f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 13:10:41 2024 +0300

    update test

commit a715a93
Author: jellizaveta <e.egorova@adguard.com>
Date:   Wed Aug 21 13:05:16 2024 +0300

    update conditions

commit 01c4605
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Aug 20 21:21:42 2024 +0300

    update description, variable names and error logging

commit b9ad132
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Aug 20 20:37:37 2024 +0300

    tests/scriptlets/trusted-click-element.spec.js edited online with Bitbucket

commit a9b4c5f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Aug 20 17:55:14 2024 +0300

    update option name

commit 320881f
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Aug 20 13:37:07 2024 +0300

    update test

commit b7edbad
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Aug 20 12:56:12 2024 +0300

    update the search for a numeric value in the option and add comments and tests

commit 31e7293
Author: jellizaveta <e.egorova@adguard.com>
Date:   Tue Aug 20 00:12:43 2024 +0300

    add the ability to set the reload value

commit 6b6c3e4
Author: jellizaveta <e.egorova@adguard.com>
Date:   Mon Aug 19 11:36:36 2024 +0300

    remove changes from the wiki file

commit 1b3f2b8
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Aug 19 11:34:11 2024 +0300

    CHANGELOG.md edited online with Bitbucket

commit cee72ee
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Aug 16 21:25:37 2024 +0300

    fix the comments in the test description

commit 322da59
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Aug 16 20:45:52 2024 +0300

    update description

commit f4a5e6c
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Aug 16 20:36:45 2024 +0300

    uodate changelog

commit 19c73a7
Author: jellizaveta <e.egorova@adguard.com>
Date:   Fri Aug 16 20:14:10 2024 +0300

    Improve 'trusted-click-element' — add 'reload' option. #301
This was referenced Sep 4, 2024
Open
Closed
@adguard-bot adguard-bot mentioned this issue Sep 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jellizaveta jellizaveta

Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.27 Resolution: Fixed Status: Closed Version: Scriptlets v1.11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@adguard-bot @zloyden @slavaleleka @jellizaveta