Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instance properties of 'Response' issue in scriptlet and redirect #297

Closed
piquark6046 opened this issue Mar 5, 2023 · 2 comments
Closed

Instance properties of 'Response' issue in scriptlet and redirect #297

piquark6046 opened this issue Mar 5, 2023 · 2 comments
Assignees
@slavaleleka
Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@piquark6046
Copy link
Member

Expected and Actual Behaviors

AdGuard for Windows
Screencast.from.2023-03-05.10-19-17.webm
AdGuard Browser Extension on Brave
Screencast.from.2023-03-05.10-34-34.webm
AdGuard Browser Extension on Mozilla Firefox
Screencast.from.2023-03-05.10-36-05.webm 
#%#//scriptlet('prevent-fetch', 'https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js')
||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js$redirect=googlesyndication-adsbygoogle
@@||pagead2.googlesyndication.com/pagead/js/adsbygoogle.js

Environment

  • Operating System: Ubuntu 22.10
  • Web Browser: Mozilla Firefox Developer Edition 111.0b8; Brave 1.48.171
  • AdGuard product: AdGuard Browser extension 4.1.53

Additional Information
@piquark6046 piquark6046 added the bug Something isn't working label Mar 5, 2023
@adguard-bot adguard-bot assigned maximtop and unassigned zzebrum Apr 26, 2023
@slavaleleka
Copy link
Contributor

we need real cases where it is needed

@piquark6046
Copy link
Member Author

@slavaleleka Please take a look:
uBlockOrigin/uBlock-issues#2518 (comment)

@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop May 3, 2023
adguard pushed a commit that referenced this issue May 11, 2023
@slavaleleka
modify original response by prevent-fetch. AG-20293 #297
e7295bd 
Squashed commit of the following:

commit 5fb4979
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Thu May 11 18:46:34 2023 +0300

    use await instead of then

commit 4c4046c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 20:42:44 2023 +0300

    mark startsWith() and endsWith() helpers as deprecated

commit c21eccc
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 20:37:37 2023 +0300

    improve responseType checking condition

commit 68f3b60
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 20:33:10 2023 +0300

    fix INPUT_JSON_PATH

commit 087f934
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 20:32:36 2023 +0300

    fix assert.async()

commit dc62a81
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 15:14:13 2023 +0300

    fix imports

commit 4423117
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:44:36 2023 +0300

    Revert "update babel/runtime"

    This reverts commit abab623.

commit bb234c4
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:42:45 2023 +0300

    improve invalid param error text

commit a1bd1da
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:36:00 2023 +0300

    update changelog

commit 5e4e47c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:35:08 2023 +0300

    update changelog

commit 531ea12
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:19:55 2023 +0300

    modify original response by prevent-fetch

commit abab623
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed May 10 14:16:37 2023 +0300

    update babel/runtime
@adguard-bot adguard-bot mentioned this issue Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
bug Something isn't working Priority: P4 Release: v1.9.37 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@maximtop @adguard-bot @zzebrum @slavaleleka @piquark6046