Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'set-attr' scriptlet — add more possible values #283

Closed
Alex-302 opened this issue Jan 20, 2023 · 1 comment
Closed

Improve 'set-attr' scriptlet — add more possible values #283

Alex-302 opened this issue Jan 20, 2023 · 1 comment
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Release: v1.9.1 Resolution: Fixed Status: Closed Version: Scriptlets v1.9

Comments

@Alex-302
Copy link
Member

Alex-302 commented Jan 20, 2023 •
edited by slavaleleka
Loading

https://github.com/AdguardTeam/Scriptlets/blob/master/wiki/about-scriptlets.md#-%EF%B8%8F-set-attr
Allow to use
true, True
false, False

Using of numbers only, makes this scritplet useless.
@Alex-302 Alex-302 added the enhancement Improvement of existent feature label Jan 20, 2023
@adguard-bot adguard-bot changed the title Improve set-attr scriptlet Improve 'set-attr' scriptlet — add more possible values Jan 20, 2023
adguard pushed a commit that referenced this issue Feb 7, 2023
@AdamWr
AG-19066 Improve set-attr scriptlet. #283
19fca58 
Squashed commit of the following:

commit ce9664c
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Feb 7 12:33:01 2023 +0200

    fix changelog

commit 57651fa
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Feb 7 12:32:09 2023 +0200

    fix changelog

commit 98adddf
Merge: 914c463 16e7f7f
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Feb 7 11:11:25 2023 +0100

    Merge branch 'master' into fix/AG-19066

commit 914c463
Author: Adam Wróblewski <adam@adguard.com>
Date:   Tue Feb 7 10:41:16 2023 +0100

    Add changelog

commit 13444cf
Author: Adam Wróblewski <adam@adguard.com>
Date:   Mon Feb 6 17:15:09 2023 +0100

    Improve description
    Add examples

commit 2f46014
Author: Adam Wróblewski <adam@adguard.com>
Date:   Mon Feb 6 16:09:59 2023 +0100

    Add True and False to description

commit 0ce0e62
Author: Adam Wróblewski <adam@adguard.com>
Date:   Mon Feb 6 15:37:18 2023 +0100

    Remove unnecessary empty space

commit b1932eb
Author: Adam Wróblewski <adam@adguard.com>
Date:   Mon Feb 6 15:32:05 2023 +0100

    Improve set-attr scriptlet
    Added true and false values
@adguard-bot adguard-bot mentioned this issue Mar 14, 2023
Closed
@adguard-bot adguard-bot mentioned this issue Mar 21, 2023
Closed
@krystian3w
Copy link

krystian3w commented Mar 23, 2023 •
edited
Loading

Maybe also should be moved to CSS or pseudo-class syntax:

example.org#?#div:set-attr(foo, bar)
example.org#$#div { set-attr: "foo, bar" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Release: v1.9.1 Resolution: Fixed Status: Closed Version: Scriptlets v1.9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Alex-302 @adguard-bot @krystian3w @slavaleleka