Skip to content

Commit

Permalink
remove resolved fixmes
Browse files Browse the repository at this point in the history
  • Loading branch information
scripthunter7 committed Sep 11, 2024
1 parent 24c0f3a commit ef9b38e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/helpers/validator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,6 @@ const checkCompatibility = (

const [resource] = resources;

// FIXME (David): do we need to check empty resource with exception rules?
if (!resource.resource) {
return resource.exceptionRule;
}
Expand Down
1 change: 0 additions & 1 deletion tests/api/index.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,6 @@ describe('Test redirects api methods', () => {
},
{
actual: '||googletagmanager.com/gtag/js$script,redirect-rule=googletagmanager_gtm.js',
// FIXME (David): Double check
expected: '||googletagmanager.com/gtag/js$script,redirect-rule=google-analytics',
},
];
Expand Down

0 comments on commit ef9b38e

Please sign in to comment.