add setItems to helpers

AdguardTeam · Nov 8, 2022 · 872a9ea · 872a9ea
1 parent 600bf62
commit 872a9ea
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 28 deletions.
diff --git a/src/helpers/index.js b/src/helpers/index.js
@@ -27,3 +27,4 @@ export * from './random-response';
 export * from './get-descriptor-addon';
 export * from './parse-flags';
 export * from './match-request-props';
+export * from './local-storage-utils';
diff --git a/src/helpers/local-storage-utils.js b/src/helpers/local-storage-utils.js
@@ -0,0 +1,11 @@
+export const setItem = (key, value) => {
+    // eslint-disable-next-line no-console
+    const log = console.log.bind(console);
+    const { localStorage } = window;
+    // setItem() may throw an exception if the storage is full.
+    try {
+        localStorage.setItem(key, value);
+    } catch (e) {
+        log(`Was unable to set localStorage item due to: ${e.message}`);
+    }
+};
diff --git a/src/scriptlets/set-local-storage-item.js b/src/scriptlets/set-local-storage-item.js
@@ -1,6 +1,7 @@
 import {
     hit,
     nativeIsNaN,
+    setItem,
 } from '../helpers/index';
 
 /* eslint-disable max-len */
@@ -74,21 +75,8 @@ export function setLocalStorageItem(source, key, value) {
         return;
     }
 
-    const setItem = (key, value) => {
-        const { localStorage } = window;
-        // setItem() may throw an exception if the storage is full.
-        try {
-            localStorage.setItem(key, value);
-            hit(source);
-        } catch (e) {
-            if (source.verbose) {
-                // eslint-disable-next-line no-console
-                console.log(`Was unable to set localStorage item due to: ${e.message}`);
-            }
-        }
-    };
-
     setItem(key, keyValue);
+    hit(source);
 }
 
 setLocalStorageItem.names = [
@@ -98,4 +86,5 @@ setLocalStorageItem.names = [
 setLocalStorageItem.injections = [
     hit,
     nativeIsNaN,
+    setItem,
 ];
diff --git a/src/scriptlets/trusted-set-local-storage-item.js b/src/scriptlets/trusted-set-local-storage-item.js
@@ -1,6 +1,7 @@
 import {
     hit,
     nativeIsNaN,
+    setItem,
 } from '../helpers/index';
 
 /* eslint-disable max-len */
@@ -71,21 +72,8 @@ export function trustedSetLocalStorageItem(source, key, value) {
         parsedValue = value;
     }
 
-    const setItem = (key, value) => {
-        const { localStorage } = window;
-        // setItem() may throw an exception if the storage is full.
-        try {
-            localStorage.setItem(key, value);
-            hit(source);
-        } catch (e) {
-            if (source.verbose) {
-                // eslint-disable-next-line no-console
-                console.log(`Was unable to set localStorage item due to: ${e.message}`);
-            }
-        }
-    };
-
     setItem(key, parsedValue);
+    hit(source);
 }
 
 trustedSetLocalStorageItem.names = [
@@ -96,4 +84,5 @@ trustedSetLocalStorageItem.names = [
 trustedSetLocalStorageItem.injections = [
     hit,
     nativeIsNaN,
+    setItem,
 ];