Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider :has() as a standard pseudo-class if ExtendedCss usage is not forced by #?# rule marker #43

Closed
slavaleleka opened this issue Nov 1, 2022 · 0 comments
Closed

Consider :has() as a standard pseudo-class if ExtendedCss usage is not forced by #?# rule marker #43

slavaleleka opened this issue Nov 1, 2022 · 0 comments
Assignees
@slavaleleka
Labels
Resolution: Done Status: Closed Version: Safari v1.11.13

Comments

@slavaleleka
Copy link
Contributor

:has() pseudo-class has native implementation
https://developer.mozilla.org/en-US/docs/Web/CSS/:has

and since ExtendedCss v2 release the rule with ## marker and :has() should not be considered as ExtendedCss

const rule1 = 'example.org##.sponsored:has(.banner)';
expect(rule1.isExtendedCss()).toBeFalsy();

but :has() pseudo-class should be considered as ExtendedCss if the rule marker is #?#

const rule2 = 'example.org#?#.sponsored:has(.banner)';
expect(rule2.isExtendedCss()).toBeTruthy();

https://github.com/AdguardTeam/ExtendedCss#extended-css-has
@slavaleleka slavaleleka mentioned this issue Nov 23, 2022
Open
@adguard-bot adguard-bot reopened this Jan 9, 2023
@Versty Versty mentioned this issue Mar 27, 2023
Closed
@adguard-bot adguard-bot assigned slavaleleka and unassigned tvinzz Mar 28, 2023
adguard pushed a commit to AdguardTeam/AdGuardForSafari that referenced this issue Apr 10, 2023
@slavaleleka
Consider :has() as a standard pseudo-class if ExtendedCss usage is …
72d08f3 
…not forced by `#?#` rule marker. AG-17273

AdguardTeam/SafariConverterLib#43

Squashed commit of the following:

commit 37b13bd
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Apr 5 19:40:04 2023 +0300

    fix version parsing

commit 829fdd7
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Apr 5 16:45:32 2023 +0300

    add comment to changelog

commit 6bce013
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Wed Apr 5 16:44:14 2023 +0300

    add changelog

commit 2c167f2
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Tue Apr 4 10:45:56 2023 +0300

    update safari-converter-lib to v2.0.39

commit 76539e9
Author: Slava Leleka <v.leleka@adguard.com>
Date:   Mon Apr 3 17:28:00 2023 +0300

    parse safariVersion as float for convertRulesToJson()
@slavaleleka slavaleleka mentioned this issue Nov 9, 2023
Open
@slavaleleka slavaleleka mentioned this issue Nov 21, 2023
Closed
@scripthunter7 scripthunter7 mentioned this issue Dec 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
Resolution: Done Status: Closed Version: Safari v1.11.13
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tvinzz @adguard-bot @slavaleleka