Throw when converting a scriptlet with path option to uBO syntax #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uBO's scriptlet syntax does not support AdGuard's `[path=...]` option. To prevent conversion to invalid filter, the conversion will error when attempting to convert an AdGuard scriptlet with a path option present. Related issue: - AdguardTeam/tsurlfilter#65
|
@gorhill could you please also add some tests for it? |
|
Not sure how is thebest way to test this. I implemented using a throw because the code in there is ready to deal with exception: https://github.com/AdguardTeam/FiltersCompiler/blob/master/src/main/converter.js#L33-L44 In which case if I understand correctly, the filter will be dropped. The test for scriptlets with path modifier is at: https://github.com/AdguardTeam/FiltersCompiler/blob/master/src/test/converter.test.js#L573-L581 But not sure how to test for expected exception. |
|
I think I understand better how this is supposed to work, I will modify the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uBO's scriptlet syntax does not support AdGuard's
[path=...]option.To prevent conversion to invalid filter, the conversion will error when attempting to convert an AdGuard scriptlet with a path option present.
Related issue: