Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thestrad.com #140798

Merged
merged 8 commits into from
Jan 24, 2023
Merged

Conversation

piquark6046
Copy link
Member

@piquark6046 piquark6046 commented Jan 23, 2023

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Add your comment and screenshots

setInterval(() => {
  Array.from(document.querySelectorAll('#notice .bottom-row button[title="Options"], .footer-policy button[title="Reject All"]')).forEach((e) => {
    try { e.click() } catch {}
  }, 500)
})

None of the following rules work well:

thestrad.com#%#//scriptlet('trusted-click-element', '#notice .bottom-row button[title="Options"], .footer-policy button[title="Reject All"]', '', '1500')
thestrad.com#%#//scriptlet('trusted-click-element', '#notice .bottom-row button[title="Options"], .footer-policy button[title="Reject All"]', '', '500')
thestrad.com#%#//scriptlet('trusted-click-element', '#notice .bottom-row button[title="Options"], .footer-policy button[title="Reject All"]')

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

@Alex-302
Copy link
Member

Why three rules are required?

@piquark6046
Copy link
Member Author

piquark6046 commented Jan 23, 2023

The reason why I attach the three rules is that multiple selectors do not work.

@Alex-302
Copy link
Member

Maybe better file a bug in scriptlets repo?

@Alex-302
Copy link
Member

Got it. Maybe a small delay required after each click.

@piquark6046 piquark6046 requested a review from a team January 24, 2023 10:49
@piquark6046 piquark6046 marked this pull request as ready for review January 24, 2023 10:49
@Alex-302 Alex-302 merged commit acd98aa into AdguardTeam:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants