Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www3.nhk.or.jp #170372

Closed
adguard-bot opened this issue Jan 11, 2024 · 9 comments
Closed

www3.nhk.or.jp #170372

adguard-bot opened this issue Jan 11, 2024 · 9 comments
Assignees
Labels
A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard for iOS P4: Low T: Incorrect Blocking

Comments

@adguard-bot
Copy link

Issue URL (Incorrect Blocking)

https://www3.nhk.or.jp/nhkworld/en/news/tags/2/

Comment

(Adguard free, not paid, iOS version I have)

This website/link is loading much slower with enabled adguard???

(Adguard free, not paid, iOS version I have)

[NSFW] Screenshots

Screenshot 1

Screenshot 1

Screenshot 1 with AdGuard disabled

Screenshot 1

System configuration

Information Value
AdGuard product: AdGuard for iOS v4.5.2
License type: free
DNS filtering: disabled
Filters: Ad Blocking:
AdGuard Base,
AdGuard Mobile Ads

Privacy:
AdGuard Tracking Protection

Social Widgets:
AdGuard Social Media

Annoyances:
AdGuard Cookie Notices,
AdGuard Popups,
AdGuard Mobile App Banners,
AdGuard Other Annoyances

Language-specific:
AdGuard Russian
@zloyden
Copy link
Contributor

zloyden commented Jan 11, 2024

Not reproduced - the site opens fine on my end.
Try to clear browser data, update the filters (wait almost one minute there), open the site.
If that doesn't work, you should re-enable the content blockers in Safari settings (wait about the same time as when you update the filters).

@zloyden
Copy link
Contributor

zloyden commented Jan 11, 2024

If that does not help, contact support@adguard.com.

@zloyden zloyden closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@zloyden zloyden added A: Cannot reproduce Filters devs cannot reproduce this issue and removed T: Incorrect Blocking labels Jan 11, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Jan 19, 2024

It seems Base filter and Tracking protection filter are both chasing slowdown, at least on my Android. Checking a bit now.

@BlazDT BlazDT reopened this Jan 19, 2024
@BlazDT BlazDT removed the A: Cannot reproduce Filters devs cannot reproduce this issue label Jan 19, 2024
@github-actions github-actions bot removed the A: In progress Work on the issue is in progress label Jan 19, 2024
@BlazDT BlazDT added T: Incorrect Blocking A: In progress Work on the issue is in progress labels Jan 19, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Jan 19, 2024

Biggest culprit seems to be tracking protection, but slowdown happens even if I add this rule which normally should disable every part:
@@||nhk.co.jp^$elemhide,jsinject,content,urlblock,cookie,stealth,cookie,extension,important

Filtering log is sadly not helping much on Android :(

Document exclusion works though. Did I miss any exclusions @AdamWr? If not, looks like app bug.

@BlazDT BlazDT added the A: Waiting for data Waiting for more information from the user label Jan 19, 2024
@AdamWr
Copy link
Member

AdamWr commented Jan 19, 2024

If I'm not wrong, rules with stealth and cookie cannot be used together with another exceptions like - elemhide,jsinject,content,urlblock,extension.
This rule:

@@||nhk.or.jp^$content

seems to be working fine on my end.
Maybe related to - AdguardTeam/CoreLibs#1772
I will open new issue in CoreLibs repo. Done - AdguardTeam/CoreLibs#1855

By the way, the original issue is about iOS, so for iOS probably a different rule is needed.

AdamWr added a commit that referenced this issue Jan 19, 2024
@BlazDT
Copy link
Contributor

BlazDT commented Jan 19, 2024

I tried content exclusion alone and still slow.
Maybe a bug in latest nightly.

@AdamWr
Copy link
Member

AdamWr commented Jan 19, 2024

On my end it works fine with $content exclusion.

@Alex-302
Copy link
Member

Alex-302 commented Feb 5, 2024

But user have AdGuard for iOS, it is without HTML filtering.

@BlazDT
Copy link
Contributor

BlazDT commented Feb 5, 2024

Just checked on my iPad and not reproduced.

@Alex-302 Alex-302 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: In progress Work on the issue is in progress A: Waiting for data Waiting for more information from the user N: AdGuard for iOS P4: Low T: Incorrect Blocking
Projects
None yet
Development

No branches or pull requests

5 participants